[UI/#48] 온보딩 뷰 / UI 구현 #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boiledEgg-s
approved these changes
Jul 13, 2024
There was a problem hiding this comment.
이런 라디오버튼들도 재활용한다면 좋을 것 같네요,,,
There was a problem hiding this comment.
인정하는 부분임다,, 리팩 때 야무지게 해보아요!
Hyobeen-Park
approved these changes
Jul 13, 2024
| @@ -22,7 +22,7 @@ class MainNavigator( | |||
| @Composable get() = navController | |||
| .currentBackStackEntryAsState().value?.destination | |||
|
|
|||
| val startDestination = SignIn | |||
| val startDestination = StartFiltering | |||
arinming
approved these changes
Jul 13, 2024
Comment on lines
33
to
37
| private const val START_YEAR = 2023 | ||
| private const val END_YEAR = 2025 | ||
| private val years = | ||
| (listOf("") + (START_YEAR..END_YEAR).map { it.toString() } + listOf("") + listOf("")).toImmutableList() | ||
| private val monthsNumber = |
Comment on lines
38
to
39
| (listOf("") + (1..12).map { it.toString() } + listOf("") + listOf("")).toImmutableList() | ||
|
|
There was a problem hiding this comment.
했어야 합니다..! ㅋㅋㅋ 반영완료~!!
Comment on lines
+32
to
+33
| val isButtonValid = remember { mutableStateOf(false) } | ||
|
|
There was a problem hiding this comment.
뷰모델로 빼보려고 했는데 그 상태를 잘 기억하지 못하는 것 같아서,, 이건 다시 시도해볼게요!!
Comment on lines
+47
to
+58
| FilteringButton( | ||
| isSelected = selectedButton[index], | ||
| modifier = modifier.fillMaxWidth(), | ||
| text = if (selectedButton[index]) selectedOptions[index] else option, | ||
| onButtonClick = { | ||
| selectedIndex.intValue = option | ||
| selectedButton.indices.forEach { i -> selectedButton[i] = false } | ||
| selectedButton[index] = true | ||
| onButtonClick(index) | ||
| }, | ||
| cornerRadius = 15.dp, | ||
| paddingVertical = 15.dp |
into ui/#48-on-boarding-filtering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
Screen_Recording_20240713_093501_Terning-Android.mp4
📢 To Reviewers