Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI/#64] 스크랩 취소 다이얼로그 및 말줄임 구현 #74

Merged
merged 10 commits into from
Jul 15, 2024

Conversation

arinming
Copy link
Contributor

⛳️ Work Description

  • 스크랩 취소 다이얼로그
  • 말줄임 추가

📸 Screenshot

64.mp4

📢 To Reviewers

  • 드뎌 다이얼로그 끝 !

@arinming arinming added UI 💐 UI 작업 아린💛 아린 labels Jul 13, 2024
@arinming arinming added this to the 1차 스프린트 UI 작업 milestone Jul 13, 2024
@arinming arinming self-assigned this Jul 13, 2024
@arinming arinming linked an issue Jul 13, 2024 that may be closed by this pull request
4 tasks
Copy link
Member

@leeeyubin leeeyubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

짱큰 LGTM~~~!!!!!!!!!

Comment on lines 26 to 28

val startDestination = SignIn
val startDestination = Search

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

잡았다!!!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

잡았다!!!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

잡았다!!!

Copy link
Member

@Hyobeen-Park Hyobeen-Park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~~~~❤️❤️❤️❤️

Comment on lines 26 to 28

val startDestination = SignIn
val startDestination = Search

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

잡았다!!!


fun updateScrap(newScrap: Boolean) {
_state.value = _state.value.copy(isScrap = newScrap)
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아하 이렇게 업데이트 하면 되는군요,,,, 배워갑니다ㅎㅎㅎ

Copy link
Member

@boiledEgg-s boiledEgg-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

진짜 너무 잘한다,, LGTM LGTM 두 번 해드릴게요!

Comment on lines 26 to 28

val startDestination = SignIn
val startDestination = Search

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

잡았다!!!

@arinming arinming merged commit 84a57bd into develop Jul 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI 💐 UI 작업 아린💛 아린
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[UI] 스크랩 다이얼로그 및 말줄임 구현
4 participants