[UI/#80] 탐색 뷰 / 공고 컴포넌트 추가 #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
Hyobeen-Park
approved these changes
Jul 15, 2024
| @@ -54,7 +54,7 @@ fun InternCompanyInfo(modifier: Modifier) { | |||
| ) { | |||
| Image( | |||
| painter = painterResource( | |||
| id = R.drawable.ic_nosearch | |||
| id = R.drawable.ic_empty_logo | |||
Comment on lines
+25
to
+26
| shadowRadius = 10.dp, | ||
| shadowWidth = 2.dp, |
There was a problem hiding this comment.
흠 이게 아이템마다 radius가 다를 수 있어서 component로 뺄거면 이거도 파라미터로 받아와야 할 것 같아요..!!
leeeyubin
approved these changes
Jul 15, 2024
Comment on lines
73
to
78
| var sheetState by remember { mutableStateOf(false) } | ||
| val internSearchResultData by viewModel.internSearchResultData.collectAsStateWithLifecycle() | ||
|
|
||
|
|
||
| if (sheetState) { | ||
| SortingBottomSheet( |
Comment on lines
147
to
152
| isScrapped = true, | ||
| ), | ||
| RecommendInternData( | ||
| InternData( | ||
| imgUrl = "https://reqres.in/img/faces/7-image.jpg", | ||
| title = "[유한킴벌리] 그린캠프 w.대학생 숲 활동가", | ||
| dDay = 2, |
Comment on lines
+35
to
+38
| } | ||
|
|
||
|
|
||
| fun updateExistSearchResults(query: String) { |
Comment on lines
55
to
60
| Image( | ||
| painter = painterResource( | ||
| id = R.drawable.ic_nosearch | ||
| id = R.drawable.ic_empty_logo | ||
| ), | ||
| modifier = modifier.fillMaxWidth(), | ||
| contentDescription = null, |
There was a problem hiding this comment.
이거 서버에서 이미지 URL로 받는 거면 coil 사용해줘야 될 것 같아요!!
# Conflicts: # feature/src/main/java/com/terning/feature/home/home/HomeViewModel.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
80.mp4
📢 To Reviewers