[FEAT/#77] 홈 뷰 / 맞춤 공고 서버 통신 구현 #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mmend-intern # Conflicts: # feature/src/main/java/com/terning/feature/home/home/HomeViewModel.kt
…mmend-intern # Conflicts: # feature/src/main/java/com/terning/feature/home/home/HomeRoute.kt # feature/src/main/java/com/terning/feature/home/home/HomeViewModel.kt
leeeyubin
reviewed
Jul 15, 2024
Comment on lines
5
to
7
|
|
||
| interface InternDataSource { | ||
| suspend fun getRecommendIntern(sortBy: String): BaseResponse<RecommendInternResponseDto> |
There was a problem hiding this comment.
Home 관련된 로직이면 Home이란 단어를 먼저 써줘야 추후에 리팩할 때 찾기에도 편할 것 같아요!
There was a problem hiding this comment.
오!!! 맞아요ㅎㅎㅎ 수정하겠습니당!!
Comment on lines
74
to
75
| }.onFailure { exception: Throwable -> | ||
| _recommendInternState.value = UiState.Failure(exception.message ?: " ") |
There was a problem hiding this comment.
실패했을 때의 상태를 UiState를 활용해서 Failure로 명시해주고, 토스트는 sideEffect로 관리해주면 좋을 것 같아요!
There was a problem hiding this comment.
sideEffect!!!!! 도전해보겠습니다😎
Comment on lines
22
to
31
| // fun toRecommendInternEntity(): List<RecommendInternResponseModel> = listOf( | ||
| // RecommendInternResponseModel( | ||
| // internshipAnnouncementId = this.internshipAnnouncementId, | ||
| // title = this.title, | ||
| // dDay = this.dDay, | ||
| // workingPeriod = this.workingPeriod, | ||
| // companyImage = this.companyImage, | ||
| // isScrapped = this.isScrapped, | ||
| // ) | ||
| // ) |
There was a problem hiding this comment.
이 피알에서는 안 쓰이는 코드이면 지워줘도 될 것 같아요!
There was a problem hiding this comment.
이게 원래 코드고 밑에 있는 코드가 더미데이터인데 제가 깜빡하고 수정을 안했네요😅 수정하겠습니다 감사해요!!
arinming
approved these changes
Jul 16, 2024
| class HomeDataSourceImpl @Inject constructor( | ||
| private val homeService: HomeService | ||
| ) : HomeDataSource { | ||
| override suspend fun getRecommendIntern(sortBy: String): BaseResponse<HomeRecommendInternResponseDto> = |
There was a problem hiding this comment.
BaseResponse로 감싸기 참고합니당!! 히
| suspend fun getRecommendIntern( | ||
| @Query("sortBy") sortBy: String, | ||
| ): BaseResponse<HomeRecommendInternResponseDto> | ||
|
|
|
|
||
| sealed class HomeSideEffect { | ||
| data class ShowToast(@StringRes val message: Int) : HomeSideEffect() | ||
| data object NavigateToChangeFilter : HomeSideEffect() |
Comment on lines
63
to
64
| val homeSortByState get() = _homeSortByState.asStateFlow() | ||
|
|
There was a problem hiding this comment.
이거는 (아마도) 필터링 정보 불러올 때 다시 사용할 것 같아요!!
boiledEgg-s
approved these changes
Jul 16, 2024
| import com.terning.data.dto.response.HomeRecommendInternResponseDto | ||
|
|
||
| interface HomeDataSource { | ||
| suspend fun getRecommendIntern(sortBy: String): BaseResponse<HomeRecommendInternResponseDto> |
There was a problem hiding this comment.
Suggested change
| suspend fun getRecommendIntern(sortBy: String): BaseResponse<HomeRecommendInternResponseDto> | |
| suspend fun getRecommendIntern(sortBy: String): BaseResponse<List<HomeRecommendInternResponseDto>> |
API 명세서 확인해봤을땐 BaseResponse의 result가 직접 리스트를 관리하는 것으로 보여서 이 방식대로 수정해야되지 않나 싶네요,,
Comment on lines
91
to
97
| enum class SortBy(val sortBy: String) { | ||
| EARLIEST("deadlineSoon"), | ||
| SHORTEST("shortestDuration"), | ||
| LONGEST("longestDuration"), | ||
| SCRAP("mostScrapped"), | ||
| VIEW_COUNT("mostViewed"), | ||
| } |
…mmend-intern # Conflicts: # app/src/main/java/com/terning/point/di/DataSourceModule.kt # app/src/main/java/com/terning/point/di/RepositoryModule.kt # app/src/main/java/com/terning/point/di/ServiceModule.kt
…mmend-intern # Conflicts: # app/src/main/java/com/terning/point/di/DataSourceModule.kt # app/src/main/java/com/terning/point/di/RepositoryModule.kt # app/src/main/java/com/terning/point/di/ServiceModule.kt # data/src/main/java/com/terning/data/datasource/HomeDataSource.kt # data/src/main/java/com/terning/data/datasourceimpl/HomeDataSourceImpl.kt # data/src/main/java/com/terning/data/repositoryimpl/HomeRepositoryImpl.kt # data/src/main/java/com/terning/data/service/HomeService.kt # domain/src/main/java/com/terning/domain/repository/HomeRepository.kt # feature/src/main/java/com/terning/feature/home/home/HomeRoute.kt # feature/src/main/java/com/terning/feature/home/home/HomeSideEffect.kt # feature/src/main/java/com/terning/feature/home/home/HomeViewModel.kt
Hyobeen-Park
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
Screen_Recording_20240718_024745_Terning-Android.mp4
📢 To Reviewers