[FEAT/#72] 소셜 로그인 / 서버통신 구현 #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeeyubin
changed the title
Hyobeen-Park
approved these changes
Jul 15, 2024
| import javax.inject.Inject | ||
|
|
||
| class TerningDataStoreImpl @Inject constructor( | ||
| private val dataStore: SharedPreferences, |
There was a problem hiding this comment.
SharedPreferences 사용하는게 자동 로그인을 위한거 맞나요?!?!???
Comment on lines
96
to
97
| if (response.accessToken == null) _signInSideEffects.emit(SignInSideEffect.NavigateSignUp) | ||
| else _signInSideEffects.emit(SignInSideEffect.NavigateToHome) |
There was a problem hiding this comment.
오호!! navigate도 sideEffect로 처리하는군요!!!! 새로운거 배워갑니다❤️
Comment on lines
+5
to
+6
| <string name="server_success">서버통신에 성공했어요</string> | ||
| <string name="server_failure">서버통신에 실패했어요</string> |
| accessToken, | ||
| SignInRequestModel(platform) | ||
| ).onSuccess { response -> | ||
| tokenRepository.setTokens(response.accessToken, response.refreshToken) |
There was a problem hiding this comment.
accessToken이 null인 상황도 있는 것 같은데 tokenRepository에 null값이 들어가도 괜찮은가요??
There was a problem hiding this comment.
날카롭다,,, 그 경우를 고려 못했네요!!!! 바로 로직 수정했습니당~~!! 최고!!
arinming
approved these changes
Jul 15, 2024
Comment on lines
+68
to
71
| @JWT | ||
| fun provideJWTRetrofit( | ||
| client: OkHttpClient, | ||
| factory: Converter.Factory |
There was a problem hiding this comment.
OPEN은 오픈API를 사용했기 때문에 네이밍을 그렇게 지었습니다!
이제부터는 실제 사용할 base.url을 넣어줬기 때문에 네이밍을 수정해야 할 것 같아서 바꿔줬어요!!
boiledeggg
approved these changes
Jul 16, 2024
| private fun signInSuccess( | ||
| accessToken: String, | ||
| platform: String = KAKAO | ||
| ) { | ||
| viewModelScope.launch { |
There was a problem hiding this comment.
이렇게 여러 번 viewModelScope를 사용하신 이유가 있나요??
정지 함수를 사용할 수도 있을 것 같은데 뭔 차이가 있는지 궁금해요,,,
There was a problem hiding this comment.
적용할 수 있는 건 suspend fun 적용했습니당~!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📢 To Reviewers