[FEAT/#79] 탐색 기본 뷰 / 조회수 많은 공고 통신 #89

arinming · 2024-07-15T19:57:54Z

closed [FEAT] 탐색 기본 뷰 / 조회수 많은 공고 통신 #79

⛳️ Work Description

data, domain 설계
viewModel 설계
이미지 매핑 구현
빈 검색어 입력 시 검색 안되도록 구현

📸 Screenshot

79.mp4

📢 To Reviewers

난 너를 사랗해 ㅋ

leeeyubin

state랑 sideEffect 관리 넘넘 잘해줘서 보는 내내 행복,,,,, 진짜 성장해가는 게 보여요,,,,,최고💚💚

leeeyubin · 2024-07-15T20:42:55Z

data/src/main/java/com/terning/data/datasource/SearchViewsDataSource.kt

+
+interface SearchViewsDataSource {
+    suspend fun getSearchViews(): SearchViewsResponseDto
+}


SearchDataSource로 파일명을 해준 다음에 그 다음에 서치 관련 함수들을 넣어주면 코드 관리하기 편할 것 같아용!

개큰박수..

leeeyubin · 2024-07-15T20:44:01Z

data/src/main/java/com/terning/data/dto/response/SearchViewsResponseDto.kt

+@Serializable
+data class SearchViewsResponseDto(
+    @SerialName("status")
+    val status: Int,
+    @SerialName("message")
+    val message: String,
+    @SerialName("result")
+    val result: Result,
+) {


BaseResponse 사용해주면 이 부분 쓸 필요가 없어진답니당!

스껄허게 고쳤읍니다

leeeyubin · 2024-07-15T20:50:29Z

feature/src/main/java/com/terning/feature/search/search/SearchViewModel.kt

+class SearchViewModel @Inject constructor(
+    private val searchViewsRepository: SearchViewsRepository,


여기두 네이밍을 바꾼다면 SearchRepository로 바꿀 수 있을 것 같네용

leeeyubin · 2024-07-15T21:03:58Z

feature/src/main/java/com/terning/feature/search/search/SearchViewModel.kt

+                _sideEffect.emit(SearchViewsSideEffect.Toast(R.string.server_success))
+            }.onFailure {


서버통신에 성공했을 때는 따로 토스트 안 띄워줘도 될 것 같아용

leeeyubin · 2024-07-15T21:09:21Z

feature/src/main/java/com/terning/feature/search/search/SearchViewsState.kt

+data class SearchViewsState(
+    var searchViewsList: UiState<List<SearchViewsResponseModel>> = UiState.Loading,
+)


완벽함니다!!

leeeyubin · 2024-07-15T21:54:33Z

data/src/main/java/com/terning/data/datasourceimpl/SearchViewsDataSourceImpl.kt

+            status = 200,
+            message = "탐색 > 조회수 많은 공고를 조회하는데 성공했습니다",
+            result = SearchViewsResponseDto.Result(
+                accountments = listOf(
+                    SearchViewsResponseDto.SearchViewsData(
+                        internshipAnnouncementId = 23L,
+                        companyImage = "https://image.dongascience.com/Photo/2019/09/d2468576cecf1313437de5a883bfa2ed.jpg",


더미 데이터는 지워주는 게 좋을 것 같아용!!

Hyobeen-Park

아린씨 정말 최고야,,, 특히 sideEffect 쓰는거랑 state 관리하는 부분 정말 많이 배워갑니다!! 개큰박수!!👏🏻👏🏻👏🏻👏🏻👏🏻

Hyobeen-Park · 2024-07-15T20:35:56Z

core/src/main/java/com/terning/core/designsystem/component/textfield/TerningBasicTextField.kt

-                keyboardController?.hide()
-                focusManager.clearFocus()
-                onDoneAction?.invoke()
+                if (value.isNotEmpty() && value.isNotBlank()) {


isNotEmpty와 isNotBlank를 함께 사용하신 이유가 궁금해요!! 저는 isNotBlank가 isNotEmpty를 포함하고 있는 개념이라고 이해하고 있었거든요🥹

헉 예리하다 ㅜㅜ! 맞아요 isNotBlank 안에 isNotEmpty 개념이 포함되어서 isNotBlank만 써줘도 될 것 같습니닷

Hyobeen-Park · 2024-07-15T20:48:42Z

core/src/main/java/com/terning/core/designsystem/component/textfield/TerningBasicTextField.kt

+                if (value.isNotEmpty() && value.isNotBlank()) {
+                    keyboardController?.hide()
+                    focusManager.clearFocus()
+                    onDoneAction?.invoke()


invoke()함수 사용하지 않아도 괜찮을 것 같다는 생각이 살짝쿵 드네요..!!!

null 체크를 if문으로 하는 것으로 수정했습니다!

Hyobeen-Park · 2024-07-15T20:50:59Z

data/src/main/java/com/terning/data/datasourceimpl/SearchViewsDataSourceImpl.kt

+    private val searchService: SearchService
+): SearchViewsDataSource {
+    override suspend fun getSearchViews(): SearchViewsResponseDto {
+        return SearchViewsResponseDto(


오,, 이렇게 하는 방법이 있네요..!!

Hyobeen-Park · 2024-07-15T20:51:50Z

data/src/main/java/com/terning/data/dto/response/SearchViewsResponseDto.kt

+    @SerialName("status")
+    val status: Int,
+    @SerialName("message")
+    val message: String,
+    @SerialName("result")
+    val result: Result,


이부분 BaseResponse 사용하면 좋을 것 같아요!!

Hyobeen-Park · 2024-07-15T21:09:18Z

feature/src/main/java/com/terning/feature/search/search/SearchRoute.kt

+        viewModel.sideEffect.flowWithLifecycle(lifecycle = lifecycleOwner.lifecycle)
+            .collect { sideEffect ->
+                when (sideEffect) {
+                    is SearchViewsSideEffect.Toast -> {}


여기서 toast 확장함수 써주면 좋을 것 같아요!! sideEffect.message 쓰면 toast를 띄울 수 있다고 합니다(샤라웃 투 이유빈❤️)

Hyobeen-Park · 2024-07-15T21:51:40Z

feature/src/main/java/com/terning/feature/search/search/SearchViewModel.kt

+                    SearchViewsResponseModel(
+                        title = entity.title,
+                        companyImage = entity.companyImage,
+                        announcementId = entity.announcementId
+                    )


DTO쪽에서 매핑해주면 더 깔끔할 것 같아요!!

boiledEgg-s

역시 깔끔하네요!! 네이밍만 잘 맞춰가면 좋을 것 같아요~~

boiledEgg-s · 2024-07-16T09:34:56Z

domain/src/main/java/com/terning/domain/entity/response/SearchViewsResponseModel.kt

엔티티 네이밍에선 요청 응답 관련한 정보는 필요 없을 것 같다고 생각됩니다!!

앗 InternshipAnnouncement으로 통일하겠씁니다!

arinming added 13 commits July 15, 2024 23:43

Merge remote-tracking branch 'origin/develop' into feat/#79-search-basic

b019e89

[FEAT/#79] SearchService, DTO 추가

783674c

[FEAT/#79] 조회수 많은 공고 data 모듈 설계

a6ebc71

[FEAT/#79] 조회수 많은 공고 ViewModel 설계

a759a73

Merge remote-tracking branch 'origin/develop' into feat/#79-search-basic

a3e34da

[FEAT/#79] 조회수 많은 공고 뷰모델 호출 로직 추가

9eeedf7

[FEAT/#79] 인턴 컴포넌트에 searchViewsList 적용

3756872

[FEAT/#79] 더미데이터 연결

396e4f7

[FEAT/#79] 이미지 매핑

b5bb2cd

[FEAT/#79] 공고 상세 페이지 경로 이동

4dad804

[RENAME/#79] 공고 정보 DTO 이름 변경

572efd4

[RENAME/#79] 공고 정보 DTO 이름 변경

3375f8d

[FEAT/#79] 빈 검색어 입력 제한

a939cff

arinming added FEAT ✨ 새로운 기능 구현 아린💛 아린 labels Jul 15, 2024

arinming added this to the 1차 스프린트 서버통신 작업 milestone Jul 15, 2024

arinming requested review from Hyobeen-Park, boiledEgg-s and leeeyubin July 15, 2024 19:57

arinming self-assigned this Jul 15, 2024

leeeyubin approved these changes Jul 15, 2024

View reviewed changes

Hyobeen-Park approved these changes Jul 15, 2024

View reviewed changes

arinming added 2 commits July 16, 2024 17:44

[REFACTOR/#79] BaseResponse 수정

08d7b39

[REFACTOR/#79] 리뷰에 따른 DTO 리팩토링 및 데이터 모듈 리네임

afd35a6

arinming requested review from Hyobeen-Park and leeeyubin July 16, 2024 09:47

boiledEgg-s approved these changes Jul 16, 2024

View reviewed changes

[RENAME/#79] 리뷰에 따른 데이터 모델 리네임

4d3990d

arinming merged commit fd5dd93 into develop Jul 16, 2024
1 check passed

leeeyubin changed the title ~~[Feat/#79] 탐색 기본 뷰 / 조회수 많은 공고 통신~~ [FEAT/#79] 탐색 기본 뷰 / 조회수 많은 공고 통신 Jul 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FEAT/#79] 탐색 기본 뷰 / 조회수 많은 공고 통신 #89

[FEAT/#79] 탐색 기본 뷰 / 조회수 많은 공고 통신 #89

arinming commented Jul 15, 2024 •

edited

Loading

leeeyubin left a comment

leeeyubin Jul 15, 2024

arinming Jul 16, 2024

leeeyubin Jul 15, 2024

arinming Jul 16, 2024

leeeyubin Jul 15, 2024

leeeyubin Jul 15, 2024

leeeyubin Jul 15, 2024

leeeyubin Jul 15, 2024

Hyobeen-Park left a comment

Hyobeen-Park Jul 15, 2024

arinming Jul 16, 2024

Hyobeen-Park Jul 15, 2024

arinming Jul 16, 2024

Hyobeen-Park Jul 15, 2024

Hyobeen-Park Jul 15, 2024

arinming Jul 16, 2024

Hyobeen-Park Jul 15, 2024

Hyobeen-Park Jul 15, 2024

boiledEgg-s left a comment

boiledEgg-s Jul 16, 2024

arinming Jul 16, 2024

		class SearchViewModel @Inject constructor(
		private val searchViewsRepository: SearchViewsRepository,

		_sideEffect.emit(SearchViewsSideEffect.Toast(R.string.server_success))
		}.onFailure {

[FEAT/#79] 탐색 기본 뷰 / 조회수 많은 공고 통신 #89

[FEAT/#79] 탐색 기본 뷰 / 조회수 많은 공고 통신 #89

Conversation

arinming commented Jul 15, 2024 • edited Loading

⛳️ Work Description

📸 Screenshot

📢 To Reviewers

leeeyubin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Hyobeen-Park left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

boiledEgg-s left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

arinming commented Jul 15, 2024 •

edited

Loading