Enhance boolean search expression. #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch changes two things: 1) When using custom Tokenizer, enables searching for UUIDs, product names and other items with dashes in their names by counting only space and dash character as an expression instead of just dash (see: teamtnt#161, teamtnt#215, trilbymedia/grav-plugin-tntsearch#92) 2) In some sense it partialy reverts teamtnt@33cc524 as email address parts are broken into tokens in the default Tokenizer anyway.
|
Did anyone had time to look into this? |
|
Thanks for the PR. Didn't have time to look into this yet, will try to do it today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes two things:
Searching with dash results in errors #161, Boolean search for uuid results in PHP errors #215, Exception when using boolean search type with inputs that contain two hyphens in one word trilbymedia/grav-plugin-tntsearch#92)
P.S. Negative boolean search is still completely broken. It errors out on more than one negative expression ('searchstring -test -test2') and it returns incorrect results with one negative expression ('searchstring -test'). I will try to investigate this further.