Add managed group set/remove policy functionality #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AlexandrosAlexiou
commented
Oct 8, 2023
AlexandrosAlexiou
commented
- Added Remove-TeamViewerPolicyFromManagedGroup.ps1 to allow for managed groups policy removal.
- Updated Set-TeamViewerManagedGroup.ps1 to allow for managed groups policy assignment (TeamViewer policy, Monitoring policy, Patch Management policy).
- Added and updated Docs.
- Added and updated tests.
AlexandrosAlexiou
force-pushed
the
Enrich-Managed-Groups-Policy-Management
branch
from
f072e16 to
3c01438
Compare
There was a problem hiding this comment.
Is Confirm-PolicyParametersProvided required. Isn't it possible to combine them with mandatory and parametersetnames? Please investigate
There was a problem hiding this comment.
Removed Confirm-PolicyParametersProvided and simplified the whole logic.
Mandatory parameters do not do the trick here since we do not want to force parameters to be provided for the script to work. eg. In case the user wants to change the group name and does not wish to modify the group policy.
If I am missing something please let me know.
Cmdlets/TeamViewerPS.psd1
Outdated
There was a problem hiding this comment.
This file was considered to be moved by git during the directory structure modification. Please update it with latest changes from the main branch
AlexandrosAlexiou
force-pushed
the
Enrich-Managed-Groups-Policy-Management
branch
from
3c01438 to
0b8d5bf
Compare
karthickgandhiTV
approved these changes
Oct 25, 2023
AlexandrosAlexiou
force-pushed
the
Enrich-Managed-Groups-Policy-Management
branch
from
0b8d5bf to
f75da9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.