Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Joomla 4 issued certificate design and filter issue fixes #143

Open
wants to merge 1 commit into
base: dev-joomla4
Choose a base branch
from
Open

Joomla 4 issued certificate design and filter issue fixes #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 24 additions & 2 deletions src/components/com_tjcertificate/administrator/views/bulktrainingrecord/tmpl/edit_bs5.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

?>
<div class="tj-page">
<div class="row-fluid">
<div class="row">
<form action=""
method="post" enctype="multipart/form-data" name="adminForm" id="adminForm" class="form-validate add-records">
<?php if (!empty( $this->sidebar))
Expand All @@ -60,7 +60,7 @@
<?php
echo HTMLHelper::_('bootstrap.startTabSet', 'myTab', array('active' => 'general'));
echo HTMLHelper::_('bootstrap.addTab', 'myTab', 'general', Text::_('COM_TJCERTIFICATE_TITLE_CERTIFICATE')); ?>
<div class="row-fluid">
<div class="row ptb-20 plr-10">
<?php
if ($this->isAgencyEnabled)
{
Expand Down Expand Up @@ -96,3 +96,25 @@
});

</script>

<style type="text/css">
.ptb-20 {
padding-top: 20px;
padding-bottom: 20px;
}
.plr-10{
padding-left: 10px;
padding-right: 10px;
}
.chosen-container-single .chosen-single {
height: 40px;
border: 1px solid #457abc52;
}
.chosen-container-multi .chosen-choices {
padding: 0.5rem 0.5rem 0.5rem 0.5rem;
border: 1px solid #457abc52;
}
.chosen-container {
width: 100%!important;
}
</style>
26 changes: 24 additions & 2 deletions src/components/com_tjcertificate/administrator/views/trainingrecord/tmpl/edit.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
HTMLHelper::_('script', 'com_tjcertificate/certificate.min.js', $options);
?>
<div class="tj-page">
<div class="row-fluid">
<div class="row">
<form action="<?php echo Route::_('index.php?option=com_tjcertificate&view=trainingrecord&layout=edit&id=' . (int) $this->item->id, false);?>"
method="post" enctype="multipart/form-data" name="adminForm" id="adminForm" class="form-validate">
<?php if (!empty( $this->sidebar))
Expand All @@ -57,7 +57,7 @@
<?php
echo HTMLHelper::_('bootstrap.startTabSet', 'myTab', array('active' => 'general'));
echo HTMLHelper::_('bootstrap.addTab', 'myTab', 'general', Text::_('COM_TJCERTIFICATE_TITLE_CERTIFICATE')); ?>
<div class="row-fluid">
<div class="row ptb-20 plr-10">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MeghaBiranje row-fluid is for bs2 and this might be needed for joomla 3
create separate layouts for bs3 and bs5 if needed

<?php echo $this->form->renderField('id'); ?>

<?php
Expand Down Expand Up @@ -123,3 +123,25 @@ class="p-5"
var attachmentMaxSize = '<?php echo $this->uploadLimit; ?>';

</script>
<style type="text/css">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MeghaBiranje Add css in respective CSS class and use wrapper classes like tjBs5/tjBs3 or maybe extension wrapper if this is specific to some bootstrap version

.ptb-20 {
padding-top: 20px;
padding-bottom: 20px;
}
.plr-10{
padding-left: 10px;
padding-right: 10px;
}
.chosen-container-single .chosen-single {
height: 40px;
border: 1px solid #457abc52;
}
.chosen-container-multi .chosen-choices {
padding: 0.5rem 0.5rem 0.5rem 0.5rem;

border: 1px solid #457abc52;
}
.chosen-container {
width: 100%!important;
}
</style>
2 changes: 1 addition & 1 deletion src/components/com_tjcertificate/site/models/fields/users.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
*
* @since __DEPLOY_VERSION__
*/
class UserFields extends JFormFieldList
class JFormFieldUsers extends JFormFieldList
{
/**
* The form field type.
Expand Down