Merge pull request #44 from techno-dwarf-works/feature/refactoring

Version 0.0.41
techno-dwarf-works · Aug 11, 2024 · 98ab46a · 98ab46a
1 parent d6303a8
commit 98ab46a
Show file tree

Hide file tree

Showing 4 changed files with 28 additions and 8 deletions.
diff --git a/Editor/Drawers/BasePropertyDrawer.cs b/Editor/Drawers/BasePropertyDrawer.cs
@@ -80,9 +80,10 @@ public sealed override VisualElement CreatePropertyGUI(SerializedProperty proper
             TypeHandlersBinder = HandlerBinderRegistry.GetMap<THandler>();
 
             PopulateContainer(container);
-
             container.Use();
-
+
+            var subState = StyleDefinition.CombineSubState(typeof(TAttribute).Name, GetType().Name);
+            container.RootElement.AddToClassList(subState);
             return container.RootElement;
         }
 

diff --git a/Editor/Drawers/Container/ElementsContainer.cs b/Editor/Drawers/Container/ElementsContainer.cs
@@ -113,19 +113,27 @@ private void ScheduleUpdateGeometry(GeometryChangedEvent changedEvent)
         {
             if (changedEvent.target is not PropertyField element) return;
 
-            element.schedule.Execute(OnGeometryChanged);
+            element.schedule.Execute(() => OnGeometryChanged(element));
         }
 
-        private void OnGeometryChanged()
+        private void OnGeometryChanged(VisualElement element)
         {
-            var label = RootElement.Query<Label>().Class(PropertyField.labelUssClassName).First();
+            var propertyPath = SerializedProperty.propertyPath;
+            var propertyFields = element.Query<PropertyField>().Where(field => field.bindingPath.CompareOrdinal(propertyPath)).Build();
+            var parentField = propertyFields.First();
+            var labels = parentField.Query<Label>().Class(PropertyField.labelUssClassName).Where(field =>
+            {
+                var firstAncestor = field.GetFirstAncestorOfType<PropertyField>();
+                return firstAncestor != null && firstAncestor.Equals(parentField);
+            });
+            var label = labels.First();
             if (label != null)
             {
                 LabelContainer.Setup(label);
             }
             else
             {
-                LabelContainer.Reset();
+                LabelContainer.SoftReset();
             }
         }
     }

diff --git a/Editor/Helpers/LabelContainer.cs b/Editor/Helpers/LabelContainer.cs
@@ -27,7 +27,7 @@ public void Setup(Label label)
             //TODO: Add validation for label
             _label = label;
             _styleContainer.Setup(_label.style);
-            
+
             Rebuild();
         }
 
@@ -47,5 +47,16 @@ public void Reset()
             _label = null;
             _styleContainer.Reset();
         }
+
+        public void SoftReset()
+        {
+            if (_label is { panel: not null })
+            {
+                return;
+            }
+
+            _label = null;
+            _styleContainer.Reset();
+        }
     }
 }
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "com.tdw.better.commons",
   "displayName": "Better Commons",
-  "version": "0.0.40",
+  "version": "0.0.41",
   "unity": "2021.3",
   "description": " ",
   "dependencies": {