feat(k3s): Add option to set MetalLB interfaces #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berendt
suggested changes
Oct 4, 2024
| @@ -30,3 +30,4 @@ metal_lb_mode: layer2 | |||
| metal_lb_available_timeout: 240s | |||
| metal_lb_controller_tag_version: v0.14.3 | |||
| metal_lb_ip_range: 192.168.30.80-192.168.30.90 | |||
| metal_lb_interfaces: | |||
There was a problem hiding this comment.
Should this be an empty list by default?
There was a problem hiding this comment.
This way I can have a condition on this in metallb.crs.j2. If empty, no interfaces are set in the L2Advertisement resource, which in turn triggers the default of metallb: https://metallb.universe.tf/configuration/_advanced_l2_configuration/#specify-network-interfaces-that-lb-ip-can-be-announced-from
Let me know if there's a better default and I'll adjust.
|
Also add a description of the new parameter in roles/k3s_server_post/meta/main.yml. |
|
@kuboschek hey! Just wanted to check in to see if you could possibly make a few adjustments |
|
Happy to make some adjustments. I’ll schedule time for this on the weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Checklist
site.ymlplaybookreset.ymlplaybook