Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove vermerke & remove nav links in getting started screen #87

Merged
merged 1 commit into from
Oct 21, 2024
Merged

feat: remove vermerke & remove nav links in getting started screen #87

merged 1 commit into from
Oct 21, 2024

Conversation

raphael-arce
Copy link
Contributor

@raphael-arce raphael-arce commented Oct 9, 2024 •
edited
Loading

@raphael-arce raphael-arce requested a review from aeschi October 9, 2024 13:23
@raphael-arce raphael-arce requested a review from tsboter as a code owner October 9, 2024 13:23
@vercel Vercel
Copy link

vercel bot commented Oct 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ber-gpt-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 0:22am

aeschi
aeschi approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@aeschi aeschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@aeschi
Copy link
Collaborator

aeschi commented Oct 21, 2024 •
edited
Loading

this file could also be removed @raphael-arce: https://github.com/technologiestiftung/ber-gpt-frontend/blob/feat/remove-vemerke/src/routes/note.tsx

and the routing for /note here: https://github.com/technologiestiftung/ber-gpt-frontend/blob/feat/remove-vemerke/src/main.tsx

and the system prompt for note here: https://github.com/technologiestiftung/ber-gpt-frontend/blob/feat/remove-vemerke/src/system-prompts.ts

@raphael-arce
Copy link
Contributor Author

@aeschi well spotted :) I updated and removed a few things, could you have another look? 🙏

aeschi
aeschi approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@aeschi aeschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@raphael-arce raphael-arce merged commit 33fdac8 into staging Oct 21, 2024
3 checks passed
@raphael-arce raphael-arce deleted the feat/remove-vemerke branch October 21, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeschi aeschi aeschi approved these changes

@tsboter tsboter Awaiting requested review from tsboter tsboter is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raphael-arce @aeschi