feat/icons

[ff6347]

This PR adds a data pipeline to create geojson from GTFS data for the public transport POI layers and the maki icon set used for them.

This PR does not touch any application code.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
wegweiser-frontend	❌ Failed (Inspect)			Aug 15, 2023 7:48am

[socket-security]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages	Version	New capabilities	Transitives	Size	Publisher
just-install	1.0.11	environment	+0	6.15 kB	brombal
@turf/turf	6.5.0	eval, environment	+127	8.98 MB	rowanwins

🚮 Removed packages: @typescript-eslint/[email protected], [email protected]

[vogelino]

@ff6347 Why do we need this pipeline? I'm not sure how to review this. Thx!

[ff6347]

@vogelino We added a own data set to the map to have the locations of the public transports (S + U and Busses) as reference points. Since we use custom icons and a own dataset I tried to document it so it doesn't get lost.

You can review it by telling me what is missing to understand the usage and data.

[vogelino]

You can review it by telling me what is missing to understand the usage and data.

Ok @ff6347 I get it. It seems meaningful! Is there a way for me to visually review this? Can I use this to view the icons on the maps locally? As far as I understand it prepares the geojson file for it to be used in MapTiler later? Is the current map style that we are using the result of using this geojson?

[ff6347]

You can review it by telling me what is missing to understand the usage and data.

Ok @ff6347 I get it. It seems meaningful! Is there a way for me to visually review this?

No. The produced geojson needs to be uploaded as dataset on maptiler.com and then get referenced on the map.

Can I use this to view the icons on the maps locally?

No these also need to be added to the map on maptiler.com

As far as I understand it prepares the geojson file for it to be used in MapTiler later?

Yes.

Is the current map style that we are using the result of using this geojson?

No. It is only a data layer on that map style. The one that shows the S/U-Bahn stations.

[vogelino]

All right thx. Then maybe I would explain that the resulting GeoJSON is meant to be uploaded to a map provider such as Mapbox or Maptiler. Otherwise it looks good to me. I could reproduce the steps as described in your README. There are still failing builds and deployments though. You might need to merge staging in you branch... 🤷‍♂️

[ff6347]

@vogelino any idea why this fails? I did some update on the eslint config. :/ I might need to roll this back and maybe add eslint config for the scripts separately?