-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AngularTemplateAsset support for Jade and Browserify fixes #80
Open
dankohn
wants to merge
57
commits into
techpines:master
Choose a base branch
from
shopbeam:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+360
−95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I mostly like this alot! Let me think on it. I think you did a great job of explaining the benefits of the framework. |
Also added support for defining transforms and externals on BrowserifyAsset
👍 to this Readme. I completely agree that emphasizing "the static web" misleads people into thinking AssetRack isn't useful with dynamic content, when it's actually most useful when used with dynamic content. |
Open
…s assets+ * Update readme with examples * Change `root` option to `templateCacheDirname`: more descriptive
Latest browserify
No error thrown if asset doesn't exist
More robust watching
* boblauer/latest-browserify: Better watching on less files No error thrown if asset doesn't exist More robust watching Browserify filename optional A more flexible way to define requires Uncommented error handling Switched from bundle.require to bundle.add for entry point file Updated browserify version
* fork/angular-templates-client-variable: add `clientVariable` option to `AngularTemplatesAsset` and update readme
* fork/angular-templates-asset: fix backwards compatibility with previous version of angular-templates assets+ fix recursing directories for angular templates & add root option AngularTemplates asset should compile jade Conflicts: lib/README.md lib/modules/angular-templates.coffee
* fork/browserify-prepend-option: bugfix bugfix bugfixing and refactoring allow multiple assets to be prepended Add `prepend` option to BrowserifyAsset and update readme Conflicts: lib/modules/browserify.coffee
This was referenced Nov 14, 2013
Closed
This reverts commit 4a310f3.
need support for variable interpolation in media queries
Update stylus
bump version number
bump version number so npm can quit being stupid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request:
Merges @boblauer's latest-browserify branch - Update browserify + enhancements to BrowserifyAsset
Now correctly passes debug option to browserify bundles (although it still does not work when compress is true because uglify's api is broken)
Fixes #82
merge #107 AngularTemplatesAsset compiles jade
merge #109 Add prepend option to BrowserifyAsset
merge #110 Add clientVariable option to AngularTemplatesAsset