Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AngularTemplateAsset support for Jade and Browserify fixes #80

Open
wants to merge 57 commits into
base: master
Choose a base branch
from

Conversation

dankohn
Copy link

@dankohn dankohn commented Jun 23, 2013

This pull request:

Merges @boblauer's latest-browserify branch - Update browserify + enhancements to BrowserifyAsset
Now correctly passes debug option to browserify bundles (although it still does not work when compress is true because uglify's api is broken)

Fixes #82
merge #107 AngularTemplatesAsset compiles jade
merge #109 Add prepend option to BrowserifyAsset
merge #110 Add clientVariable option to AngularTemplatesAsset

@techpines
Copy link
Owner

I mostly like this alot!

Let me think on it. I think you did a great job of explaining the benefits of the framework.

Also added support for defining transforms and externals on
BrowserifyAsset
@boblauer
Copy link

👍 to this Readme. I completely agree that emphasizing "the static web" misleads people into thinking AssetRack isn't useful with dynamic content, when it's actually most useful when used with dynamic content.

@bryanchriswhite bryanchriswhite mentioned this pull request Nov 1, 2013
bryanchriswhite and others added 19 commits November 2, 2013 00:41
…s assets+

* Update readme with examples
* Change `root` option to `templateCacheDirname`: more descriptive
No error thrown if asset doesn't exist
* boblauer/latest-browserify:
  Better watching on less files
  No error thrown if asset doesn't exist
  More robust watching
  Browserify filename optional
  A more flexible way to define requires
  Uncommented error handling
  Switched from bundle.require to bundle.add for entry point file
  Updated browserify version
* fork/angular-templates-client-variable:
  add `clientVariable` option to `AngularTemplatesAsset` and update readme
* fork/angular-templates-asset:
  fix backwards compatibility with previous version of angular-templates assets+
  fix recursing directories for angular templates & add root option
  AngularTemplates asset should compile jade

Conflicts:
	lib/README.md
	lib/modules/angular-templates.coffee
* fork/browserify-prepend-option:
  bugfix
  bugfix
  bugfixing and refactoring
  allow multiple assets to be prepended
  Add `prepend` option to BrowserifyAsset and update readme

Conflicts:
	lib/modules/browserify.coffee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AngularTemplatesAsset should support Jade templates
8 participants