Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Signup Endpoint #27

Closed
wants to merge 3 commits into from
Closed

Added Signup Endpoint #27

wants to merge 3 commits into from

Conversation

ryanjung1998
Copy link
Contributor

No testing created yet

Signed-off-by: ryanjung1998 <[email protected]>
@ParsaKargari ParsaKargari requested a review from Axeloooo December 6, 2023 01:18
@Axeloooo
Copy link
Collaborator

Axeloooo commented Dec 6, 2023

To Do @ryanjung1998

  • Make sure you are up to date with the dev branch
  • Hash the password using the bcrypt dependency
  • Create a session in the req.session.user field
  • Return a status code of 201
  • Create tests for your implementation under the authentication.test.ts file
  • Validate the existence of the cookie found in the response.header["set-cookie"][0] field from response after a test request using the http object was sent

@ryanjung1998 ryanjung1998 linked an issue Dec 8, 2023 that may be closed by this pull request
@Axeloooo Axeloooo closed this Jan 14, 2024
@Axeloooo Axeloooo deleted the Signup branch February 4, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Sign Up Endpoint
2 participants