merch gallery api files #7
Open
+61
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
brian-ngyn
reviewed
Apr 3, 2024
routes/merchgallery.js
Outdated
|
|
||
| router.get("/merchgallery", async (req, res) => { | ||
| //show the orign of the request | ||
| console.log("client IP: ", req.ip, ", connects to merch endpoint of TechStart server"); |
There was a problem hiding this comment.
I don't think we should be logging the user's IP here
brian-ngyn
reviewed
Apr 3, 2024
routes/merchgallery.js
Outdated
| const retrieveAlbum = async () => { | ||
| try { | ||
| // URL for the Google Photos album | ||
| const albumUrl =process.env.GOOGLE_MERCH_PHOTOS_URL; |
There was a problem hiding this comment.
Add a missing space between "=" and "process"
const albumUrl = process.env.GOOGLE_MERCH_PHOTOS_URL;
brian-ngyn
reviewed
Apr 3, 2024
| } | ||
| } catch (error) { | ||
| console.error("Error fetching album:", error); | ||
| throw new Error("Error fetching album"); |
There was a problem hiding this comment.
Are you intentially throwing an error inside the catch block?
Anidion
approved these changes
Apr 3, 2024
Signed-off-by: Sahitiakella <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.