Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forbid use of os.path.join, point user to tmt._compat.Path #3210

Merged
merged 3 commits into from
Sep 26, 2024
Merged

Forbid use of os.path.join, point user to tmt._compat.Path #3210

merged 3 commits into from
Sep 26, 2024

Conversation

happz
Copy link
Collaborator

@happz happz commented Sep 12, 2024

Pull Request Checklist

  • implement the feature

@happz happz added code | style Code style changes not affecting functionality code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. labels Sep 12, 2024
@happz happz added this to the 1.37 milestone Sep 12, 2024
martinhoyer
martinhoyer approved these changes Sep 12, 2024
View reviewed changes
Copy link
Collaborator

@martinhoyer martinhoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely

tests/discover/data/distgit_test_plugin.py Show resolved Hide resolved
@happz happz added the ci | full test Pull request is ready for the full test execution label Sep 12, 2024
@happz happz force-pushed the forbid-os.path.join branch from 37dd4be to a85dde5 Compare September 12, 2024 12:38
@happz happz marked this pull request as draft September 12, 2024 13:59
@happz happz changed the title Forbid use of os.path, point user to tmt._compat.Path Forbid use of os.path.join, point user to tmt._compat.Path Sep 12, 2024
@happz happz force-pushed the forbid-os.path.join branch 3 times, most recently from 123bd9c to 991e14b Compare September 24, 2024 14:10
@happz happz marked this pull request as ready for review September 24, 2024 14:10
@happz happz force-pushed the forbid-os.path.join branch from 991e14b to 182ebee Compare September 26, 2024 12:17
@happz happz force-pushed the forbid-os.path.join branch from 182ebee to f971c9c Compare September 26, 2024 14:47
@happz happz added the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Sep 26, 2024
@happz
Copy link
Collaborator Author

happz commented Sep 26, 2024

Unrelated failure, merging.

@happz happz merged commit 1e0cee2 into main Sep 26, 2024
22 of 23 checks passed
@happz happz deleted the forbid-os.path.join branch September 26, 2024 18:58
The-Mule pushed a commit to The-Mule/tmt that referenced this pull request Oct 14, 2024
@happz @The-Mule
Forbid use of os.path.join, point user to tmt._compat.Path (teemtee#3210
8d840ca 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinhoyer martinhoyer martinhoyer approved these changes

@therazix therazix therazix approved these changes

@dav-pascual dav-pascual Awaiting requested review from dav-pascual

@psss psss Awaiting requested review from psss psss is a code owner

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@thrix thrix Awaiting requested review from thrix thrix is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

Assignees
No one assigned
Labels
ci | full test Pull request is ready for the full test execution code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. code | style Code style changes not affecting functionality status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish.
Projects
None yet
Milestone
1.37
Development

Successfully merging this pull request may close these issues.
3 participants
@happz @martinhoyer @therazix