Skip to content

Commit

Permalink
fix beforePr fail-fast
Browse files Browse the repository at this point in the history
  • Loading branch information
robstoll committed Oct 20, 2024
1 parent cb5ff1c commit 206d84e
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions scripts/before-pr.sh
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,12 @@ sourceOnce "$scriptsDir/cleanup-on-push-to-main.sh"
sourceOnce "$scriptsDir/run-shellcheck.sh"

function beforePr() {
runShellspecIfInstalled

# using && because this function is used on the left side of an || in releaseFiles
# this way we still have fail fast behaviour and don't mask/hide a non-zero exit code
checkInBugTemplate && \
customRunShellcheck && \
cleanupOnPushToMain
runShellspecIfInstalled &&
checkInBugTemplate &&
customRunShellcheck &&
cleanupOnPushToMain
}

${__SOURCED__:+return}
Expand Down

0 comments on commit 206d84e

Please sign in to comment.