Fix the order of locking between MetricRepository and Sensor to prevent deadlock #34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently lock on
MetricRepository
is taken first and thenSensor
's lock is taken in some cases and the opposite is happening is some other cases, leading to deadlock if both these cases happen around the same time. Fix is to change the order of locking to always take lock onMetricRepository
first and then takeSensor
's lock whenever theMetricRepository
is accessed inSensor
to prevent deadlock.