Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the order of locking between MetricRepository and Sensor to prevent deadlock #34

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

m-nagarajan
Copy link
Collaborator

Currently lock on MetricRepository is taken first and then Sensor's lock is taken in some cases and the opposite is happening is some other cases, leading to deadlock if both these cases happen around the same time. Fix is to change the order of locking to always take lock on MetricRepository first and then take Sensor's lock whenever the MetricRepository is accessed in Sensor to prevent deadlock.

Copy link
Contributor

@FelixGV FelixGV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link

@lluwm lluwm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @m-nagarajan !

@m-nagarajan m-nagarajan merged commit 151b08d into tehuti-io:master Oct 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants