Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024 05 29 lenght2 patch #34

Merged
merged 2 commits into from
Aug 10, 2024
Merged

2024 05 29 lenght2 patch #34

merged 2 commits into from
Aug 10, 2024

Conversation

sjib
Copy link
Contributor

@sjib sjib commented May 29, 2024

Solves #32

@sjib sjib requested a review from jpdupuy May 29, 2024 15:38
@sjib sjib self-assigned this May 29, 2024
@sjib
Copy link
Contributor Author

sjib commented May 29, 2024

pre-commit.ci - errors:
difficult to skip this as these are values to add:

datamodel/changelogs/0001/03_tdh_db_sia405.sql: INSERT INTO tdh_vl.structure_discharge_type (code, vsacode, value_en, value_de, value_fr, value_it, value_ro, abbr_en, abbr_de, abbr_fr, abbr_it, abbr_ro, active) VALUES (8237,8237,'**wastewater**','Abwasser','eaux_usees', '', '', '', '', '', '', '', 'true');
datamodel/changelogs/0001/09_tdh_dictionaries.sql: INSERT INTO tdh_sys.dictionary_od_values (class_id, attribute_id, value_id, table_name, field_name, value_name, value_name_en, shortcut_en, value_name_de, shortcut_de, value_name_fr, shortcut_fr, value_name_it, shortcut_it, value_name_ro, shortcut_ro, value_description_en, value_description_de, value_description_fr, value_description_it, value_description_ro) VALUES (8009,8232,8237,'structure','discharge_type','**wastewater**','wastewater',NULL,'Abwasser',NULL,'eaux_usees',NULL,NULL,NULL,NULL,NULL,NULL,NULL,NULL,NULL,NULL);


All other errors are comments that could be eliminated, once we have adapted the scripts completely to district_heating - merged #43 to eliminate

@sjib sjib closed this Aug 10, 2024
@sjib sjib reopened this Aug 10, 2024
@sjib sjib merged commit f35039f into main Aug 10, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant