Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEP-0147: introducing matrix.strategy #7180

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pritidesai
Copy link
Member

Changes

Introducing matrix.strategy to allow pipeline authors to specify explicit combinations dynamically.

apiVersion: tekton.dev/v1
kind: Pipeline
spec:
  tasks:
    - name: clone
      taskRef:
        name: clone
    - name: build
       matrix:
         strategy: $(tasks.setup.results.matrix) # <JSON payload of a list of params and values>

where $(tasks.setup.results.matrix) could be set to:

{"include":  [{"IMAGE": "image", "DOCKERFILE": "path/to/Dockerfile"}]}

or

{"include":  [{"IMAGE": "image-1", "DOCKERFILE": "path/to/Dockerfile1"},
                    {"IMAGE": "image-2", "DOCKERFILE": "path/to/Dockerfile2"},
                    {"IMAGE": "image-3", "DOCKERFILE": "path/to/Dockerfile3"}]}

#7170
tektoncd/community#1081

/kind feature

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tekton-robot tekton-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. release-note-none Denotes a PR that doesnt merit a release note. labels Oct 6, 2023
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from pritidesai after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 6, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/matrix_types.go 100.0% 92.6% -7.4
pkg/apis/pipeline/v1/pipeline_validation.go 99.1% 99.2% 0.0
pkg/apis/pipeline/v1beta1/matrix_types.go 100.0% 94.3% -5.7
pkg/apis/pipeline/v1beta1/pipeline_validation.go 98.8% 98.8% 0.0

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 10, 2023
Signed-off-by: Priti Desai <[email protected]>
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 20, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/matrix_types.go 100.0% 92.6% -7.4
pkg/apis/pipeline/v1/pipeline_validation.go 99.2% 99.2% 0.0
pkg/apis/pipeline/v1beta1/matrix_types.go 100.0% 94.3% -5.7
pkg/apis/pipeline/v1beta1/pipeline_validation.go 98.9% 98.9% 0.0

@afrittoli afrittoli closed this Feb 26, 2024
@afrittoli afrittoli reopened this Feb 26, 2024
@afrittoli
Copy link
Member

@pritidesai are you still working on TEP-0147?

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/matrix_types.go 100.0% 92.6% -7.4
pkg/apis/pipeline/v1/pipeline_validation.go 99.2% 99.2% 0.0
pkg/apis/pipeline/v1beta1/matrix_types.go 100.0% 94.3% -5.7
pkg/apis/pipeline/v1beta1/pipeline_validation.go 99.0% 99.0% 0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. release-note-none Denotes a PR that doesnt merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants