Reusable actions to restest GitHub actions #2330
Conversation
tekton-robot
added
the
kind/feature
tekton-robot
added
the
size/L
There was a problem hiding this comment.
Overall this looks good, just a few minor comments below.
Would it be worth also adding workflow templates for these in tektoncd/.github to make them easier to adopt in the other projects?
.github/actions/_slash.yml
Outdated
| # - /land: invokes the land-command workflow, to land (merge) PRs | ||
| # stacked through ghstack |
There was a problem hiding this comment.
This should be replaced with our retest command, or just reference the other action file instead since that already includes documentation.
.github/actions/_chatops_retest.yml
Outdated
|
|
||
| - name: Create comment | ||
| if: ${{ failure() && steps.landStack.outcome == 'failure' }} | ||
| uses: peter-evans/create-or-update-comment@v4 |
There was a problem hiding this comment.
we should probably pin actions by sha and let dependabot take care of updating them as needed
tekton-robot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AlanGreene, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
afrittoli
force-pushed
the
reusable_retest_workflow
branch
from
ed3d217 to
6a2d693
Compare
Signed-off-by: Andrea Frittoli <[email protected]>
afrittoli
force-pushed
the
reusable_retest_workflow
branch
from
6a2d693 to
312972e
Compare
| GITHUB_PULL_URL: ${{ github.event.client_payload.github.payload.issue.pull_request.url }} | ||
|
|
||
| - name: Create comment | ||
| if: ${{ failure() && steps.landStack.outcome == 'failure' }} |
There was a problem hiding this comment.
Should this reference the Rerun Failed Actions step instead?
Changes
/kind feature
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.