ADD deprecatedFeatures counters #4476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgalan
commented
Jan 15, 2024
| @@ -249,7 +249,7 @@ orionCurl --url /v1/updateContext -X POST --payload "$payload" > | |||
|
|
|||
| # Get statistics | |||
|
|
|||
| orionCurl --url /statistics?options | |||
| orionCurl --url /statistics | |||
There was a problem hiding this comment.
Not directly related with the purpose of this PR, this is just a typo fix.
NTC
|
@fisuda this PR does a slight modification to a couple of .md documents. It would be great if you could sync the Japanese translation, please. Thanks! |
mapedraza
reviewed
Jan 16, 2024
|
|
||
| { | ||
| "counters": { | ||
| "deprecatedFeatures": { |
There was a problem hiding this comment.
Suggested change
| "deprecatedFeatures": { | |
| "deprecatedRequests": { |
Maybe the name of this field should be deprecatedRequests in order to align with the rest of the field?
There was a problem hiding this comment.
As discussed on teams, NTC
There was a problem hiding this comment.
Discussed at Teams.
Although most of the counters are xxxxRequests, in this case, it seems better deprecatedFeatures.
NTC
|
I sent the PR #4483. Thanks. |
fgalan
added a commit
that referenced
this pull request
Jan 16, 2024
(JP) ADD deprecatedFeatures counters (#4476)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.