Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entities consistency script #4490

Merged
merged 7 commits into from
Jan 24, 2024

Conversation

fgalan
Copy link
Member

@fgalan fgalan commented Jan 23, 2024

Issue #4481

@fgalan fgalan requested a review from mapedraza January 23, 2024 14:15

# Checks done:
#
# 1. heck that there is no duplication in _id fields (for mongo {_id: {x: 1, y: 2}} and {_id: {y:2, x:1}} are different documents)
Copy link
Member Author

@fgalan fgalan Jan 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now in "Rule 15: not swapped subkeys in _id"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NTC

# Checks done:
#
# 1. heck that there is no duplication in _id fields (for mongo {_id: {x: 1, y: 2}} and {_id: {y:2, x:1}} are different documents)
# 2. All attribute in 'attrs' are in 'attrNames' and the other way around
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now in "Rule 14: mdNames field consistency"

NTC

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now in "Rule 16: location field consistency"

NTC

Copy link
Collaborator

@mapedraza mapedraza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mapedraza mapedraza merged commit 9c7c5f1 into master Jan 24, 2024
12 checks passed
@mapedraza mapedraza deleted the hardening/4481_entities_consistency_script branch January 24, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants