-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX 3001_mqtt_alarms removing dependency on external MQTT broker #4638
Conversation
test/functionalTest/mosquitto_passwd
Outdated
@@ -0,0 +1 @@ | |||
user1:$7$101$eqgU7wUvh4Y3VQAm$ovEPI43qOwAskK5M+OFmNJAoXtLRx5GI2tBjTX4AOf3ZTB79IRv1CMgbHrPnKY+/K/RKMm2i/XFp9syteeOCvg== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing dangerous here :) This is just the codification of "xxxx"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NTC (informative)
6ff9406
to
25ed111
Compare
A lot of testing (around 50 commits :) in this PR, so I have rebase and force push to clean it up. |
.github/workflows/functional.yml
Outdated
mosquitto-extra: | ||
# Needed by MQTT notification tests (multi broker) | ||
#image: eclipse-mosquitto:2.0.11 | ||
image: eclipse-mosquitto:1.6.15 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The MQTT broker in 1883 uses 2.0.11 version without problem (see L59), but this auxiliar MQTT broker in 1884 has to be 1.6.15 or 3001_mqtt/mqtt_subscription_multibroker.test will break.
It's weird... I'm looking at it.
As a side-improvement, MQTT broker version has been updated from 1.6.7 to 2.0.11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Problema found in PR #4637
Maybe mqtt.flespi.io is no longer available... better not depending on any external MQTT service.
Working locally:
but unsure about GitAction configuration... let's see