Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX 3001_mqtt_alarms removing dependency on external MQTT broker #4638

Merged
merged 6 commits into from
Jan 17, 2025

Conversation

fgalan
Copy link
Member

@fgalan fgalan commented Jan 13, 2025

Problema found in PR #4637

Maybe mqtt.flespi.io is no longer available... better not depending on any external MQTT service.

Working locally:

(p3) fermin@bodoque:~/src/fiware-orion/test/functionalTest$ ./testHarness.sh  cases/3001_mqtt_alarms/
lun 13 ene 2025 16:42:48 CET
Run tests 0 to 0
0001/4: mqtt_alarms_log_summary.test .................................................................................  28 seconds
0002/4: mqtt_alarms_none.test ........................................................................................  04 seconds
0003/4: mqtt_alarms_raise_and_release.test ...........................................................................  07 seconds
0004/4: mqtt_alarms_raise_repeat_and_release.test ....................................................................  08 seconds
Total test time: 47.01 seconds

but unsure about GitAction configuration... let's see

  • valgrind-nocache.yml
  • valgrind.yml
  • test/functionalTest/mosquittoConf/README.md

@@ -0,0 +1 @@
user1:$7$101$eqgU7wUvh4Y3VQAm$ovEPI43qOwAskK5M+OFmNJAoXtLRx5GI2tBjTX4AOf3ZTB79IRv1CMgbHrPnKY+/K/RKMm2i/XFp9syteeOCvg==
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing dangerous here :) This is just the codification of "xxxx"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NTC (informative)

@fgalan
Copy link
Member Author

fgalan commented Jan 16, 2025

A lot of testing (around 50 commits :) in this PR, so I have rebase and force push to clean it up.

mosquitto-extra:
# Needed by MQTT notification tests (multi broker)
#image: eclipse-mosquitto:2.0.11
image: eclipse-mosquitto:1.6.15
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The MQTT broker in 1883 uses 2.0.11 version without problem (see L59), but this auxiliar MQTT broker in 1884 has to be 1.6.15 or 3001_mqtt/mqtt_subscription_multibroker.test will break.

It's weird... I'm looking at it.

@fgalan
Copy link
Member Author

fgalan commented Jan 16, 2025

As a side-improvement, MQTT broker version has been updated from 1.6.7 to 2.0.11

@fgalan fgalan requested a review from mapedraza January 16, 2025 21:27
Copy link
Collaborator

@mapedraza mapedraza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mapedraza mapedraza merged commit ac1c836 into master Jan 17, 2025
17 checks passed
@mapedraza mapedraza deleted the fix-3001-tests branch January 17, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants