Merge pull request #237 from telefonicaid/fix/log_get_protocol

Fix/log get protocol
telefonicaid · Mar 5, 2021 · 7f269e1 · 7f269e1
2 parents 0d655fe + 77ada79
commit 7f269e1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/CHANGES_NEXT_RELEASE b/CHANGES_NEXT_RELEASE
@@ -1,3 +1,4 @@
+- Fix: log about getProtocol result
 - Fix: ensure protocol exists before remove it (#234)
 - Fix: print URI in logs about redirection error (#232)
 - Upgrade NodeJS version from 10 to 12 in Dockerfile due to Node 10 End-of-Life

diff --git a/lib/services/protocolData.js b/lib/services/protocolData.js
@@ -87,13 +87,14 @@ function getProtocol(protocol, callback) {
     };
     const query = Protocol.model.find(condition).sort();
 
-    query.exec(function (error, protocol) {
-        if (!error && protocol && protocol.length === 1) {
-            callback(null, protocol[0]);
+    query.exec(function (error, protocolFound) {
+        if (!error && protocolFound && protocolFound.length === 1) {
+            callback(null, protocolFound[0]);
         } else if (error) {
             callback(error);
         } else {
-            callback(new errors.ProtocolNotFound(protocol));
+            const resource = 'n/a';
+            callback(new errors.ProtocolNotFound(resource, protocol));
         }
     });
 }