Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add endpoint and transport to configurations (device groups) #328

Merged
merged 4 commits into from
Dec 20, 2023
Merged

add endpoint and transport to configurations (device groups) #328

merged 4 commits into from
Dec 20, 2023

Conversation

AlvaroVega
Copy link
Member

@AlvaroVega AlvaroVega commented Dec 13, 2023 •
edited
Loading

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 13, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7274769050

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 76.49%
Totals Coverage Status
Change from base Build 7168310008: 0.0%
Covered Lines: 512
Relevant Lines: 632
💛 - Coveralls

@AlvaroVega AlvaroVega marked this pull request as ready for review December 19, 2023 16:14
@AlvaroVega AlvaroVega requested a review from fgalan December 19, 2023 16:14
@AlvaroVega AlvaroVega changed the title add endpoint and transport add endpoint and transport to configurations (device groups) Dec 20, 2023
fgalan
fgalan reviewed Dec 20, 2023
View reviewed changes
Changelog Outdated Show resolved Hide resolved
fgalan
fgalan approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@fgalan fgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fgalan fgalan merged commit b6b594d into master Dec 20, 2023
5 checks passed
@fgalan fgalan deleted the task/add_transport_endpoint_configuration branch December 20, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgalan fgalan fgalan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlvaroVega @fgalan