Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task/add delete devices #331

Merged
merged 5 commits into from
Feb 20, 2024
Merged

Task/add delete devices #331

merged 5 commits into from
Feb 20, 2024

Conversation

AlvaroVega
Copy link
Member

@AlvaroVega AlvaroVega commented Feb 14, 2024 •
edited
Loading

@coveralls
Copy link

coveralls commented Feb 14, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7959598102

Details

  • 0 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 76.515%
Totals Coverage Status
Change from base Build 7450055897: 0.03%
Covered Lines: 513
Relevant Lines: 633
💛 - Coveralls

@AlvaroVega AlvaroVega marked this pull request as ready for review February 16, 2024 14:20
@AlvaroVega AlvaroVega requested a review from fgalan February 19, 2024 07:12
fgalan
fgalan reviewed Feb 19, 2024
View reviewed changes
CHANGES_NEXT_RELEASE Outdated Show resolved Hide resolved
fgalan
fgalan approved these changes Feb 19, 2024
View reviewed changes
Copy link
Member

@fgalan fgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Waiting for LGTM at PR telefonicaid/iotagent-node-lib#1579 to merge both PRs at once.

@fgalan fgalan merged commit 7e320dd into master Feb 20, 2024
6 checks passed
@fgalan fgalan deleted the task/add_delete_devices branch February 20, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgalan fgalan fgalan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlvaroVega @coveralls @fgalan