Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Including Lazy, Commands, Internal and Static Attributes in payload to IoT Agent Manager #793

Merged
merged 3 commits into from
Dec 17, 2020
Merged

Including Lazy, Commands, Internal and Static Attributes in payload to IoT Agent Manager #793

merged 3 commits into from
Dec 17, 2020

Conversation

Cerfoglg
Copy link
Contributor

Fix for Issue #768

@Cerfoglg Cerfoglg changed the title Including Lazy, Commands, Internal and Static Attributes in payload to IoT Agent Manager WIP: Including Lazy, Commands, Internal and Static Attributes in payload to IoT Agent Manager Jun 12, 2019
@chicco785 chicco785 force-pushed the fix/iotagent-manager-payload branch from 60f8412 to be710a1 Compare June 13, 2019 16:33
@chicco785
Copy link
Contributor

@Cerfoglg till test are not fixed, please rename to WIP: ...

@chicco785 chicco785 force-pushed the fix/iotagent-manager-payload branch 3 times, most recently from 45a686e to 3ec712f Compare August 5, 2019 17:33
@Cerfoglg Cerfoglg changed the title WIP: Including Lazy, Commands, Internal and Static Attributes in payload to IoT Agent Manager Including Lazy, Commands, Internal and Static Attributes in payload to IoT Agent Manager Aug 6, 2019
@chicco785 chicco785 mentioned this pull request Dec 27, 2019
Merged
@fgalan fgalan mentioned this pull request Jul 14, 2020
Closed
@fgalan
Copy link
Member

fgalan commented Oct 7, 2020

We are considering merging PR #831 and this PR may be impacted (see more details here). However, any potential conflict is very easy to solve (I understand @jason-fox may provide details, if needed).

Is this PR still active? @Cerfoglg @chicco785 do you agree in merging PR #831 before your PR?

@chicco785
Copy link
Contributor

sure, let us now when when ready

@fgalan
Copy link
Member

fgalan commented Nov 19, 2020

sure, let us now when when ready

PR #831 has been merged, so now it's ready :)

The PR would need some adaptation to solve the conflicts. Basically:

  1. Solve the conflict accepting your changes
  2. Change style with npm run prettier

(Please @jason-fox amend mi if I'm wrong)

@chicco785 chicco785 force-pushed the fix/iotagent-manager-payload branch from 3ec712f to e4dec2a Compare November 19, 2020 17:28
@Cerfoglg @chicco785
Added lazy, commands, static and internal attributes to the payload s…
221b6f6 
…ent to the IoT Agent Manager

* Added lazy, commands, static and internal attributes to the payload sent to the IoT Agent Manager
* updated tests
@chicco785 chicco785 force-pushed the fix/iotagent-manager-payload branch from e4dec2a to 221b6f6 Compare November 19, 2020 17:31
@chicco785
Copy link
Contributor

it looks like some already introduced support for commands and static attributes, thus this pr actually adds only lazy and internal_attributes.

@chicco785
Copy link
Contributor

@fgalan this should ready for landing now

@chicco785
Copy link
Contributor

any chance to merge this PR?

@fgalan
Copy link
Member

fgalan commented Dec 15, 2020

any chance to merge this PR?

A small conflict on CNR files has arisen after merging your other PR ;)

We have some "sensitive" PRs queued (in the sense they could have impact in e2e behaviors). We are trying to have a full CI e2e pass after merging one PR and before merging the next PR. The CI e2e takes a long time and is executed typically by night, so we are progressing slowly.

Be patient, pls... I think that sooner than later this PR will be the next one in queue :)

@chicco785
Copy link
Contributor

chicco785 commented Dec 15, 2020 •
edited
Loading

any chance to merge this PR?

A small conflict on CNR files has arisen after merging your other PR ;)

fixed by 64563fb

We have some "sensitive" PRs queued (in the sense they could have impact in e2e behaviors). We are trying to have a full CI e2e pass after merging one PR and before merging the next PR. The CI e2e takes a long time and is executed typically by night, so we are progressing slowly.

Be patient, pls... I think that sooner than later this PR will be the next one in queue :)

sure!

AlvaroVega
AlvaroVega approved these changes Dec 17, 2020
View reviewed changes
Copy link
Member

@AlvaroVega AlvaroVega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fgalan
fgalan approved these changes Dec 17, 2020
View reviewed changes
Copy link
Member

@fgalan fgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fgalan fgalan merged commit 70d8bcc into telefonicaid:master Dec 17, 2020
@fgalan fgalan mentioned this pull request Dec 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgalan fgalan fgalan approved these changes

@AlvaroVega AlvaroVega AlvaroVega approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Cerfoglg @chicco785 @fgalan @AlvaroVega