Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add node listener upgrade #31

Merged
merged 2 commits into from
Oct 28, 2015
Merged

add node listener upgrade #31

merged 2 commits into from
Oct 28, 2015

Conversation

XavierVal
Copy link
Contributor

No description provided.

{
"name": "TimeInstant",
"type": "ISO8601",
"value": "2015-10-28T13:51:32+0100"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the date parsing logic strong enough to cope with miliseconds in the case the value includes it? It will work if timezone is not included?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The miliseconds are not counted, the diff is based on seconds. It will require some tunning on how it gets the diff.
The time parser AFAIK converts all kind of formats, I have checked with this samples:
"value": "2015-10-28T13:51:32"
"value": "2015-10-28 13:51:32"
"value": "2015-10-28T13:51:32+0100"
"value": "2015-10-28T13:51:32.0011"
and even the now_time is calculated always in the same way it calculates the diff properly.
NTC

@fgalan
Copy link
Member

fgalan commented Oct 28, 2015

LGTM

Not sure if I should merge (it seems that I privilegies in the iot-qa-tools repo :) or should I wait for other to do it...

@iariasleon
Copy link
Contributor

LGTM

iariasleon pushed a commit that referenced this pull request Oct 28, 2015
@iariasleon iariasleon merged commit 79232c8 into develop Oct 28, 2015
@iariasleon iariasleon deleted the task/upgradelistener branch October 28, 2015 15:15
@manucarrace
Copy link
Contributor

I've always wished to have a readme file for each one of the simulators. It's a nice to have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants