Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include media sizes to exports #28943

Merged
merged 1 commit into from
Feb 9, 2025

Conversation

anton-ryzhov
Copy link
Contributor

I hope this suggestion could be classified as "fixing the existing user experience" and therefore considered.

Currently it is possible to include various media types and set a size limit. But it's impossible to predict how much size and time the export will take, and how much data was below and above the limit.

This change saves media sizes even for skipped items, so allows to get this insights.

I've tested my change:

  {
   "id": 111,
   "type": "message",
   "date": "2025-01-30T14:53:04",
   "date_unixtime": "1738245184",
   "from": "",
   "from_id": "",
   "photo": "(File not included. Change data exporting settings to download.)",
   "photo_size": 178404,
   "width": 960,
   "height": 1280,
   "text": "",
   "text_entities": []
  }

@CLAassistant
Copy link

CLAassistant commented Feb 8, 2025

CLA assistant check
All committers have signed the CLA.

@anton-ryzhov anton-ryzhov marked this pull request as ready for review February 8, 2025 21:17
@john-preston
Copy link
Member

Maybe photo_file_size? Because photo_size reads like dimensions..

@anton-ryzhov
Copy link
Contributor Author

I also noticed this confusion, but tried to keep it consistent. How about now?

@john-preston john-preston merged commit bee4118 into telegramdesktop:dev Feb 9, 2025
8 of 10 checks passed
@john-preston
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants