Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/stuff #84

Merged
merged 9 commits into from
Oct 14, 2024
Merged

Fix/stuff #84

merged 9 commits into from
Oct 14, 2024

Conversation

rndmh3ro
Copy link
Collaborator

@moritzrp wanna take a look? :)

@rndmh3ro rndmh3ro requested a review from schurzi October 10, 2024 09:39
@moritzrp
Copy link
Contributor

moritzrp commented Oct 10, 2024

Looks good from my side! Only a small thing: Since the description can be a list as well, I would add it to the annotation of RoleDefault. So description: Union[str, list[str]] instead of just description: str. I missed that part.

Edit: Also for the add_default method.

Copy link
Contributor

@schurzi schurzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are also some references to PyYAML in .pre-commit-config.yaml, should the be removed too?

@rndmh3ro
Copy link
Collaborator Author

@moritzrp, thanks for noticing! Fixed this.

@schurzi, thanks for this. I noticed that there was still pyyaml used in the core-functions. I removed it there, too and replaced it with ruamel.yaml. I also changed the handling of defaults and made it hopefully simpler.

Ready to review now.

@rndmh3ro rndmh3ro merged commit fcc872b into main Oct 14, 2024
5 checks passed
@rndmh3ro rndmh3ro deleted the fix/stuff branch October 14, 2024 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants