-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/stuff #84
Conversation
Looks good from my side! Only a small thing: Since the description can be a list as well, I would add it to the annotation of RoleDefault. So Edit: Also for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are also some references to PyYAML in .pre-commit-config.yaml
, should the be removed too?
@moritzrp wanna take a look? :)