-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: refactors props for multiple component documentation in storybook #2370
base: main
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -46,10 +46,7 @@ export const PATH = | |
control: { | ||
type: 'text', | ||
}, | ||
}, | ||
styles: { | ||
control: { disable: true }, | ||
}, | ||
} | ||
}} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. add the style here again since without it the component is not working correctly |
||
/> | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -39,7 +39,6 @@ | |
:focusable="focusable" | ||
:decorative="decorative" | ||
:accessibility-title="accessibilityTitle" | ||
:styles="styles" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. add the style back here to make the storybook work |
||
/> | ||
</div> | ||
</template> | ||
|
@@ -55,7 +54,6 @@ export default { | |
focusable: { type: Boolean, default: false }, | ||
decorative: { type: Boolean, default: false }, | ||
accessibilityTitle: { type: String }, | ||
styles: { type: String } | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. add the style back here to make the storybook work |
||
} | ||
} | ||
</script> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can also add the description for these attributes here :
e.g. for
hcmLabelDisabled
https://github.com/telekom/scale/blob/main/packages/components/src/components/dropdown-select/readme.md?plain=1#L17