#946 | Display the function names when possible on transactions table #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testnet-teloscan ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for teloscan-stage ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dev-mainnet-teloscan ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for zkevm-testnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pmjanus
approved these changes
Jan 27, 2025
pmjanus
deleted the
946-display-the-function-names-when-possible-on-transactions-table
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #946
Description
This PR enhances the way the component MethodField obtains the function's name. If the contract parsing fails, it falls back to the abi section of the response which may contain a function signatures map.
Test scenarios
Before:
https://testnet.teloscan.io/address/0x689F601fA828C089B1DC1D7530595684fF9f84D6?tab=transactions
After:
https://deploy-preview-951--testnet-teloscan.netlify.app/address/0x689F601fA828C089B1DC1D7530595684fF9f84D6?tab=transactions
