-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge sdk dashboards into one #59
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool stuff! 👍
i think this does make things a bit easier, but think it will be difficult to be used by actual polyglot microservices. i know its a bit harder to maintain, but to me at least given the differences in metrics by our diff sdk currently doing this is just easier for users as they can just pick the one dashboard that works, instead of seeing a lot of "noice" |
In practice though, how often are you going to be looking at timer metrics across all your services at once? I would imagine that it's more useful to see metrics for a single app at a time rather than all at a time. ServiceA is likely not going to perform like ServiceB, even if they're on the same SDK. |
Thank you both, My understanding is that this graph is meant to serve as a starting point, and users should/will adapt it according to their needs. I am not sure what users do know when they have run polyglot microservices. Can they add custom labels to the scraper configuration?
this is a good point. Users can modify the runtime configuration to set 'durations_as_seconds=true' or they can modify the dashboards. Maybe we can add some documentation in the readme.md |
@kevinawoo @tsurdilo I have created a new pr with two dashboards #60 |
What was changed
Merged both dashboards into one to make it easier to maintain.
Some panels have two queries when the metric name for Java/Go and Core SDK does not match. Final users can ignore or delete queries that do not report data for their SDK
Why?
Checklist
Closes
How was this tested: