Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to SDK 1.0.0 #43

Merged
merged 1 commit into from
Dec 5, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Temporalio" Version="0.1.0-beta2" />
<PackageReference Include="Temporalio.Extensions.DiagnosticSource" Version="0.1.0-beta2" />
<PackageReference Include="Temporalio.Extensions.Hosting" Version="0.1.0-beta2" />
<PackageReference Include="Temporalio.Extensions.OpenTelemetry" Version="0.1.0-beta2" />
<PackageReference Include="Temporalio" Version="1.0.0" />
<PackageReference Include="Temporalio.Extensions.DiagnosticSource" Version="1.0.0" />
<PackageReference Include="Temporalio.Extensions.Hosting" Version="1.0.0" />
<PackageReference Include="Temporalio.Extensions.OpenTelemetry" Version="1.0.0" />
<!--
Can also reference the SDK downloaded to a local directory:
<ProjectReference Include="$(MSBuildThisFileDirectory)..\temporal-sdk-dotnet\src\Temporalio\Temporalio.csproj" />
Expand Down
5 changes: 0 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,6 @@

This is the set of .NET samples for the [.NET SDK](https://github.com/temporalio/sdk-dotnet).

⚠️ UNDER ACTIVE DEVELOPMENT

The .NET SDK and is under active development and has not released a stable version yet. APIs may change in incompatible
ways until the SDK is marked stable.

## Usage

Prerequisites:
Expand Down
2 changes: 1 addition & 1 deletion src/ActivityHeartbeatingCancellation/MyActivities.cs
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ public static async Task FakeProgressAsync(int sleepIntervalMs = 1000)
try
{
// Allow for resuming from heartbeat
var startingPoint = ActivityExecutionContext.Current.Info.HeartbeatDetails.Any()
var startingPoint = ActivityExecutionContext.Current.Info.HeartbeatDetails.Count > 0
? await ActivityExecutionContext.Current.Info.HeartbeatDetailAtAsync<int>(0)
: 1;

Expand Down
4 changes: 2 additions & 2 deletions src/ClientMtls/Program.cs
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,9 @@ void AddClientCommand(
Tls = new()
{
ClientCert =
File.ReadAllBytes(ctx.ParseResult.GetValueForOption(clientCertOption)!.FullName),
await File.ReadAllBytesAsync(ctx.ParseResult.GetValueForOption(clientCertOption)!.FullName),
ClientPrivateKey =
File.ReadAllBytes(ctx.ParseResult.GetValueForOption(clientKeyOption)!.FullName),
await File.ReadAllBytesAsync(ctx.ParseResult.GetValueForOption(clientKeyOption)!.FullName),
},
});
// Run
Expand Down
Loading