Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix temporal server start up error #307

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

coolyrat
Copy link
Contributor

@coolyrat coolyrat commented Oct 8, 2023

What was changed

Update the serverjwtauth sample to compatible with the latest temporal server version

Why?

Before making the change, docker-compose up the temporal server error when start. And the README.md is not updated after v1.20.0

Checklist

  1. Closes

  2. How was this tested:

After the change, can run the sample successfully

  1. Any docs updates needed?

Updated README.md to help others from having the same problem

@CLAassistant
Copy link

CLAassistant commented Oct 8, 2023

CLA assistant check
All committers have signed the CLA.

@dnr
Copy link
Member

dnr commented Oct 9, 2023

Note that this fixes #301

@metavee
Copy link

metavee commented Jan 23, 2024

This solved a really annoying error for me - thanks for sharing the fix!

@cretz cretz merged commit 107dfa9 into temporalio:main Jan 23, 2024
4 checks passed
@cretz
Copy link
Member

cretz commented Jan 23, 2024

Thanks! Sorry it took so long to get this in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants