Add sleep-for-days sample #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
| sigChan.Receive(ctx, &isComplete) | ||
| }) | ||
|
|
||
| for !isComplete { |
There was a problem hiding this comment.
Might be simpler to just check the signal channel every loop, also this sample is a bit different then the python one temporalio/samples-python@2f3f2ac. In the python one your signal takes no input, but the Go one does. I think we should match python here.
There was a problem hiding this comment.
Removed the signal input (and workflow input).
Quinn-With-Two-Ns
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple sample demonstrating Temporal's ability to sleep for days and still execute reliably.
##What was changed
added sleep-for-days sample
Any docs updates needed?
I believe so @webchick