Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds test example for hello_update.py #118

Merged
merged 7 commits into from
Jul 22, 2024

Conversation

yashvanzara
Copy link
Contributor

What was changed

adds test example for hello_update.py

Why?

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

@CLAassistant
Copy link

CLAassistant commented May 26, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a couple of minor things

tests/hello/hello_update_test.py Outdated Show resolved Hide resolved
tests/hello/hello_update_test.py Show resolved Hide resolved
@cretz
Copy link
Member

cretz commented May 28, 2024

(also note Python samples CI is broken, we are fixing in #119 now)

@yashvanzara yashvanzara requested a review from cretz May 28, 2024 19:09
@cretz
Copy link
Member

cretz commented May 28, 2024

This test looks good, thanks! But I think CI is failing for a known update bug fix we haven't released yet. In temporalio/sdk-python#521 we made sure that workflows and updates completed in the same task are properly handled. You may be able to update to Python SDK 1.6.1 to check (update pyproject.toml to 1.6.1 then poetry update temporalio), but otherwise it may have to wait until next release.

@yashvanzara
Copy link
Contributor Author

This test looks good, thanks! But I think CI is failing for a known update bug fix we haven't released yet. In temporalio/sdk-python#521 we made sure that workflows and updates completed in the same task are properly handled. You may be able to update to Python SDK 1.6.1 to check (update pyproject.toml to 1.6.1 then poetry update temporalio), but otherwise it may have to wait until next release.

No worries, just thought of adding the test while I was exploring the update feature and did not find a test for it. Can wait 👍

Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure you reformat (e.g. poe format), CI is currently failing

@yashvanzara
Copy link
Contributor Author

Make sure you reformat (e.g. poe format), CI is currently failing

Yep, my bad - I had just accepted the suggestion you shared - fixed now

Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@cretz cretz merged commit 276aaf7 into temporalio:main Jul 22, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants