Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dev-server instructions in README #129

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

josh-berry
Copy link
Contributor

  • Add a link to how to install the Temporal CLI
  • Fix the link that shows how to launch the dev server

Closes #127.

@josh-berry josh-berry requested a review from a team July 19, 2024 17:16
@CLAassistant
Copy link

CLAassistant commented Jul 19, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Comment on lines +11 to +12
* [Temporal CLI installed](https://docs.temporal.io/cli#install)
* [Local Temporal server running](https://docs.temporal.io/cli/server#start-dev)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure these need to be separate links, can just say it needs to be running probably, but not a big deal

- Add a link to how to install the Temporal CLI
- Fix the link that shows how to launch the dev server

Closes #127.
@josh-berry josh-berry force-pushed the josh/readme-broken-link-127 branch from 2d8382b to edfcfce Compare July 22, 2024 15:00
@josh-berry josh-berry merged commit 5ae603e into main Jul 22, 2024
9 checks passed
@josh-berry josh-berry deleted the josh/readme-broken-link-127 branch July 22, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Broken link in Python examples readme
3 participants