-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding encryption example using a KMS and JWT-based auth #138
base: main
Are you sure you want to change the base?
Conversation
Thanks! Added some review comments. Also may want to |
Thanks @cretz for all of the great feedback. I'll make these updates in the next day or two and will let you know! |
Thanks for all the suggestions, @cretz. I think I've addressed everything. Let me know if you have any more feedback. |
Make need to run |
Should be good to go now, @cretz. Thanks again! |
@phillipskevin - Looks like there's a type error. Specifically, since we allow our Python samples to run in in all non-EOL Python versions, you have to change things like For this error:
You may need to add a dependency for https://pypi.org/project/types-requests. Have not investigated this. |
Looks like CI is still failing after adding the |
Looks like it's still complaining on 3.8. I admittedly have not spent time digging into this. |
Python 3.8 went end of life last week, so having some trouble testing it now. Will the versions used in CI be updated? Or will you continue to support 3.8 for some time? |
I suspect we will EOL it too soon, though no specific timeline. EDIT: Opened temporalio/sdk-python#672 for dropping 3.8 support. |
No description provided.