Expose workflow cancel cause #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
reviewed
Feb 11, 2025
There was a problem hiding this comment.
I think this may be needed on the child/external cancel commands outbound from workflow too. And we should decide if we want to call this "cause" or "reason" (API is inconsistent but we don't have to be)
6 tasks
Sushisource
force-pushed
the
expose-cancel-cause
branch
from
2563d45 to
0a43e6b
Compare
cretz
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Expose cancellation cause from user requests
Why?
Checklist
Closes [Bug] Core doesn't expose the
causefromWorkflowExecutionCancelRequestedEventAttributes#708How was this tested:
Upgraded integ test
Any docs updates needed?