Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[api-go] Add test for proxy to make sure all payloads are visited even if it's not reachable #1809

Open
Quinn-With-Two-Ns opened this issue Feb 10, 2025 · 0 comments
Open

[api-go] Add test for proxy to make sure all payloads are visited even if it's not reachable #1809

Quinn-With-Two-Ns opened this issue Feb 10, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@Quinn-With-Two-Ns
Copy link
Contributor

Quinn-With-Two-Ns commented Feb 10, 2025 •
edited by josh-berry
Loading

Is your feature request related to a problem? Please describe.
The proxy should visit all payloads even if they are not reachable by the workflow service

Describe the solution you'd like
Add a test that somehow makes sure every payload is visited even if it's not reachable from workflow service.

An ideal approach would be to confirm payload encoding in all the existing integration tests rather than trying to build a contrived one. The key is we use a different way of discovering/walking payloads vs. what is used to walk them on encoding.

Additional context
temporalio/api-go#209
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Quinn-With-Two-Ns