Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix update.Response getting skipped by the proxy #209

Merged
merged 2 commits into from
Feb 10, 2025
Merged

Fix update.Response getting skipped by the proxy #209

merged 2 commits into from
Feb 10, 2025

Conversation

Quinn-With-Two-Ns
Copy link
Contributor

What

Add update.Response to proxy

Why?

Without this change payloads under update.Response are skipped by the proxy. This can cause update results to not go through the proxy.

How did you test it?

New unit test added

@Quinn-With-Two-Ns Quinn-With-Two-Ns requested review from a team as code owners February 10, 2025 06:06
cretz
cretz approved these changes Feb 10, 2025
View reviewed changes
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can we open a separate issue to have a test that somehow makes sure every payload is visited even if it's not reachable from workflow service? I can think of a few ways to write it.

@Quinn-With-Two-Ns Quinn-With-Two-Ns mentioned this pull request Feb 10, 2025
Open
@Quinn-With-Two-Ns
Copy link
Contributor Author

@cretz temporalio/sdk-go#1809 done

@cretz
Copy link
Member

cretz commented Feb 10, 2025

Thanks, this LGTM, merge away

@Quinn-With-Two-Ns
Copy link
Contributor Author

@cretz Can you please re-review I also noticed we didn't handle any in the failure case

@Quinn-With-Two-Ns Quinn-With-Two-Ns merged commit dad8b16 into master Feb 10, 2025
4 checks passed
@Quinn-With-Two-Ns Quinn-With-Two-Ns deleted the add-update-response-proxy branch February 10, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanos stephanos stephanos approved these changes

@cretz cretz cretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Quinn-With-Two-Ns @cretz @stephanos