Return error instead of just logging it if client fails (#1632)

ten-protocol · Nov 1, 2023 · aae2f5f · aae2f5f
1 parent fb4c449
commit aae2f5f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/tools/walletextension/accountmanager/account_manager.go b/tools/walletextension/accountmanager/account_manager.go
@@ -69,8 +69,9 @@ func (m *AccountManager) ProxyRequest(rpcReq *wecommon.RPCRequest, rpcResp *inte
 		err = m.subscriptionsManager.HandleNewSubscriptions(clients, rpcReq, rpcResp, userConn)
 		if err != nil {
 			m.logger.Error("Error subscribing to multiple clients")
+			return err
 		}
-		return err
+		return nil
 	}
 	return m.executeCall(rpcReq, rpcResp)
 }

diff --git a/tools/walletextension/wallet_extension.go b/tools/walletextension/wallet_extension.go
@@ -249,6 +249,7 @@ func (w *WalletExtension) AddAddressToUser(hexUserID string, message string, sig
 	encClient, err := common.CreateEncClient(w.hostAddr, addressFromMessage.Bytes(), privateKeyBytes, signature, w.Logger())
 	if err != nil {
 		w.Logger().Error(fmt.Errorf("error creating encrypted client for user: (%s), %w", hexUserID, err).Error())
+		return fmt.Errorf("error creating encrypted client for user: (%s), %w", hexUserID, err)
 	}
 
 	accManager.AddClient(addressFromMessage, encClient)