Skip to content

Commit

Permalink
address pr comments
Browse files Browse the repository at this point in the history
  • Loading branch information
tudor-malene committed Feb 16, 2024
1 parent fa853d1 commit df5cd4c
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions go/enclave/nodetype/sequencer.go
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ func (s *sequencer) createGenesisBatch(block *common.L1Block) error {
// this is the actual first block produced in chain
err = s.blockchain.IngestNewBlock(batch)
if err != nil {
return fmt.Errorf("unable to remove ingest new block into eth blockchain - %w", err)
return fmt.Errorf("failed to feed batch into the virtual eth chain - %w", err)
}

// the mempool can only be started after at least 1 block is in the blockchain object
Expand Down Expand Up @@ -282,7 +282,7 @@ func (s *sequencer) produceBatch(
// add the batch to the chain so it can remove pending transactions from the pool
err = s.blockchain.IngestNewBlock(cb.Batch)
if err != nil {
return nil, fmt.Errorf("unable to remove tx from mempool - %w", err)
return nil, fmt.Errorf("failed to feed batch into the virtual eth chain - %w", err)
}

return cb, nil
Expand Down
4 changes: 2 additions & 2 deletions go/enclave/nodetype/validator.go
Original file line number Diff line number Diff line change
Expand Up @@ -108,11 +108,11 @@ func (val *obsValidator) ExecuteStoredBatches() error {
if err != nil {
return fmt.Errorf("could not store executed batch %s. Cause: %w", batch.Hash(), err)
}
val.batchRegistry.OnBatchExecuted(batch, receipts)
err = val.mempool.Chain.IngestNewBlock(batch)
if err != nil {
return fmt.Errorf("unable to remove ingest new block into eth blockchain - %w", err)
return fmt.Errorf("failed to feed batch into the virtual eth chain- %w", err)
}
val.batchRegistry.OnBatchExecuted(batch, receipts)
}
}
return nil
Expand Down
4 changes: 2 additions & 2 deletions integration/constants.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@ package integration
// Tracks the start ports handed out to different tests, in a bid to minimise conflicts.
const (
StartPortEth2NetworkTests = 10000
StartPortTenscanUnitTest = 12000
StartPortNodeRunnerTest = 14000
StartPortTenGatewayUnitTest = 16000
StartPortSimulationGethInMem = 18000
StartPortSimulationInMem = 22000
StartPortSimulationFullNetwork = 26000
Expand All @@ -13,8 +15,6 @@ const (
StartPortWalletExtensionUnitTest = 38000
StartPortFaucetUnitTest = 42000
StartPortFaucetHTTPUnitTest = 48000
StartPortTenscanUnitTest = 12000
StartPortTenGatewayUnitTest = 16000

DefaultGethWSPortOffset = 100
DefaultGethAUTHPortOffset = 200
Expand Down

0 comments on commit df5cd4c

Please sign in to comment.