Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hardhat: ensure token script doesn't spin when waiting #1508

Merged
merged 2 commits into from
Sep 11, 2023
Merged

hardhat: ensure token script doesn't spin when waiting #1508

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68c1421
hardhat: ensure token script doesn't spin when waiting
BedrockSquirrel Sep 11, 2023
0293874
Restore deleted log msg
BedrockSquirrel Sep 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions contracts/deployment_scripts/testnet/layer2/001_whitelist_tokens.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { Receipt } from 'hardhat-deploy/dist/types';
*/


function sleep(ms) {
async function sleep(ms) {
return new Promise((resolve) => {
setTimeout(resolve, ms);
});
Expand Down Expand Up @@ -96,7 +96,7 @@ const func: DeployFunction = async function (hre: HardhatRuntimeEnvironment) {
const messageBusContract = (await hre.ethers.getContractAt('MessageBus', '0x526c84529b2b8c11f57d93d3f5537aca3aecef9b'));
while (await messageBusContract.callStatic.verifyMessageFinalized(messages[1]) != true) {
console.log(`Messages not stored on L2 yet, retrying...`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps it's better to leave the log to see what's happening no ?

If we're tweaking this - we shouldn't do forever loops. What if this had an exit/fail condition ?

sleep(1_000);
await sleep(1_000);
}
resolve(true);
});
Expand Down