Match network configuration with Chainlist #1511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zkokelj
force-pushed
the
ziga/update_testnet_configuration_metamask
branch
from
2634b32 to
5ac5482
Compare
zkokelj
force-pushed
the
ziga/update_testnet_configuration_metamask
branch
from
daf9087 to
3b5095d
Compare
|
@zkokelj , is this blocked by something? |
tudor-malene
approved these changes
Sep 27, 2023
|
LGTM but if you do a find across the codebase for '777' I think there's a couple more worth replacing (e.g. configure-metamask.md and some mentions of "default: 777" in script comments) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change is needed
Currently MetaMask shows multiple warnings because network added does not match networks that are supported.
We want to add networks without unnecessary warnings.
What changes were made as part of this PR
Changed information about new network to match: https://github.com/ethereum-lists/chains/blob/master/_data/chains/eip155-443.json
PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks