Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obscuro Gateway Database Deploy #1514

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Obscuro Gateway Database Deploy #1514

merged 1 commit into from
Sep 13, 2023

Conversation

otherview
Copy link
Contributor

Why this change is needed

https://github.com/obscuronet/obscuro-internal/issues/2158

Adds a deployment for mariadb into a vm.

What changes were made as part of this PR

Please provide a high level list of the changes made

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

@otherview otherview requested a review from zkokelj September 13, 2023 11:31
Copy link
Contributor

@zkokelj zkokelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Minor comment on suppressing errors.

&& sudo snap refresh && sudo snap install --channel=1.18 go --classic \
&& curl -fsSL https://get.docker.com -o get-docker.sh && sh ./get-docker.sh \
&& git clone --depth 1 -b ${{ env.BRANCH_NAME }} https://github.com/obscuronet/go-obscuro.git /home/obscuro/go-obscuro \
&& docker network create --driver bridge node_network || true \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

|| true suppresses any errors. Is there any purpose for doing it?
I guess if any of the steps fail the deployment will not be sucessful

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point.
It does suppress errors but only for that if clause, so if other clauses fail then the command fails.

We want to forcibly create a node_network so that if we do create more containers they can intra-container communicate between them.

It's more of a standard, everywhere that we create docker containers we create the node-network (it then guarantees that all containers can communicate between them). Not sure if it's worth removing. Will remove it if you feel strongly about it.

@otherview otherview merged commit 2e56932 into main Sep 13, 2023
@otherview otherview deleted the pedro/og_database_deploy branch September 13, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants