Add sepolia option to L2 GH action scripts #1529

BedrockSquirrel · 2023-09-17T09:49:41Z

Why this change is needed

Add sepolia-testnet as a third option in deploy and upgrade deployment scripts.

This will require updating of github secrets to provide infura API keys and to replace PKs with more securely guarded ones.

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

PR checks reviewed and performed

tudor-malene

lgtm (but don't know much about this)

otherview

lgtm, would add a comment explaining the need of the duplicate l1ws

otherview · 2023-09-18T09:14:52Z

.github/workflows/manual-deploy-testnet-l2.yml

+      L1_WS_URL_0: ${{ steps.outputVars.outputs.L1_WS_URL_0 }}
+      L1_WS_URL_1: ${{ steps.outputVars.outputs.L1_WS_URL_1 }}


Worth adding a comment explaining the 2 WS

otherview

looks good 👍

BedrockSquirrel · 2023-09-25T11:39:36Z

testnet/launcher/l2contractdeployer/docker.go

@@ -90,7 +90,7 @@ func (n *ContractDeployer) WaitForFinish() error {
 	defer cli.Close()

 	// make sure the container has finished execution
-	err = docker.WaitForContainerToFinish(n.containerID, 3*time.Minute)
+	err = docker.WaitForContainerToFinish(n.containerID, 10*time.Minute)


3mins was sometimes too quick for sepolia, this script does quite a lot now with a few waits - don't think there's a need to rush it.

BedrockSquirrel · 2023-09-26T11:05:28Z

contracts/package.json

@@ -10,15 +10,15 @@
  "author": "",
  "license": "ISC",
  "devDependencies": {
-    "@nomicfoundation/hardhat-toolbox": "^2.0.0",
+    "@nomicfoundation/hardhat-toolbox": "~2.0.0",


Fixing these versions solved the docker image compile problem on main.

BedrockSquirrel changed the title ~~dd sepolia option to L2 GH action scripts~~ Add sepolia option to L2 GH action scripts Sep 17, 2023

tudor-malene approved these changes Sep 18, 2023

View reviewed changes

otherview approved these changes Sep 18, 2023

View reviewed changes

otherview approved these changes Sep 19, 2023

View reviewed changes

BedrockSquirrel had a problem deploying to sepolia-testnet September 19, 2023 21:42 — with GitHub Actions Failure

BedrockSquirrel had a problem deploying to sepolia-testnet September 19, 2023 22:06 — with GitHub Actions Failure

BedrockSquirrel had a problem deploying to sepolia-testnet September 19, 2023 22:25 — with GitHub Actions Error

BedrockSquirrel temporarily deployed to sepolia-testnet September 19, 2023 22:33 — with GitHub Actions Inactive

BedrockSquirrel temporarily deployed to sepolia-testnet September 21, 2023 10:36 — with GitHub Actions Inactive

BedrockSquirrel temporarily deployed to sepolia-testnet September 21, 2023 10:48 — with GitHub Actions Inactive

BedrockSquirrel had a problem deploying to sepolia-testnet September 21, 2023 10:56 — with GitHub Actions Failure

BedrockSquirrel temporarily deployed to sepolia-testnet September 22, 2023 11:09 — with GitHub Actions Inactive

BedrockSquirrel temporarily deployed to sepolia-testnet September 22, 2023 11:23 — with GitHub Actions Inactive

BedrockSquirrel had a problem deploying to sepolia-testnet September 22, 2023 11:29 — with GitHub Actions Failure

BedrockSquirrel temporarily deployed to sepolia-testnet September 22, 2023 11:29 — with GitHub Actions Inactive

BedrockSquirrel had a problem deploying to sepolia-testnet September 22, 2023 11:31 — with GitHub Actions Failure

BedrockSquirrel temporarily deployed to sepolia-testnet September 22, 2023 12:48 — with GitHub Actions Inactive

BedrockSquirrel temporarily deployed to sepolia-testnet September 22, 2023 13:00 — with GitHub Actions Inactive

BedrockSquirrel temporarily deployed to sepolia-testnet September 22, 2023 13:06 — with GitHub Actions Inactive

BedrockSquirrel had a problem deploying to sepolia-testnet September 22, 2023 13:08 — with GitHub Actions Failure

BedrockSquirrel temporarily deployed to sepolia-testnet September 22, 2023 14:00 — with GitHub Actions Inactive

BedrockSquirrel temporarily deployed to sepolia-testnet September 22, 2023 14:13 — with GitHub Actions Inactive

BedrockSquirrel temporarily deployed to sepolia-testnet September 22, 2023 14:19 — with GitHub Actions Inactive

BedrockSquirrel temporarily deployed to sepolia-testnet September 25, 2023 10:45 — with GitHub Actions Inactive

BedrockSquirrel temporarily deployed to sepolia-testnet September 25, 2023 10:52 — with GitHub Actions Inactive

BedrockSquirrel temporarily deployed to sepolia-testnet September 25, 2023 10:57 — with GitHub Actions Inactive

add sepolia option to L2 GH action scripts

b071c29

BedrockSquirrel force-pushed the matt/sepolia-testnet branch from 6d19051 to b071c29 Compare September 25, 2023 11:37

BedrockSquirrel commented Sep 25, 2023

View reviewed changes

Merge remote-tracking branch 'origin/main' into matt/sepolia-testnet

c93a41a

BedrockSquirrel had a problem deploying to dev-testnet September 25, 2023 16:24 — with GitHub Actions Failure

BedrockSquirrel added 2 commits September 25, 2023 21:55

Print GH env variables

22cbb56

missed vars prefixes

1fcb96f

BedrockSquirrel had a problem deploying to dev-testnet September 25, 2023 21:11 — with GitHub Actions Failure

BedrockSquirrel temporarily deployed to dev-testnet September 26, 2023 06:05 — with GitHub Actions Inactive

BedrockSquirrel had a problem deploying to dev-testnet September 26, 2023 06:19 — with GitHub Actions Failure

correct L1 vars and add L1 env job title

48e9164

BedrockSquirrel temporarily deployed to dev-testnet September 26, 2023 08:46 — with GitHub Actions Inactive

BedrockSquirrel had a problem deploying to dev-testnet September 26, 2023 09:05 — with GitHub Actions Failure

BedrockSquirrel had a problem deploying to dev-testnet September 26, 2023 09:36 — with GitHub Actions Failure

try fixing couple of relevant seeming versions

7243d18

BedrockSquirrel temporarily deployed to dev-testnet September 26, 2023 10:33 — with GitHub Actions Inactive

BedrockSquirrel temporarily deployed to dev-testnet September 26, 2023 10:47 — with GitHub Actions Inactive

BedrockSquirrel temporarily deployed to dev-testnet September 26, 2023 10:53 — with GitHub Actions Inactive

BedrockSquirrel temporarily deployed to dev-testnet September 26, 2023 10:54 — with GitHub Actions Inactive

BedrockSquirrel temporarily deployed to dev-testnet September 26, 2023 10:59 — with GitHub Actions Inactive

BedrockSquirrel commented Sep 26, 2023

View reviewed changes

otherview approved these changes Sep 26, 2023

View reviewed changes

BedrockSquirrel merged commit 235d0a9 into main Sep 26, 2023
11 checks passed

BedrockSquirrel deleted the matt/sepolia-testnet branch September 26, 2023 12:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add sepolia option to L2 GH action scripts #1529

Add sepolia option to L2 GH action scripts #1529

BedrockSquirrel commented Sep 17, 2023 •

edited

Loading

tudor-malene left a comment

otherview left a comment

otherview Sep 18, 2023

otherview left a comment

BedrockSquirrel Sep 25, 2023

BedrockSquirrel Sep 26, 2023

		L1_WS_URL_0: ${{ steps.outputVars.outputs.L1_WS_URL_0 }}
		L1_WS_URL_1: ${{ steps.outputVars.outputs.L1_WS_URL_1 }}

Add sepolia option to L2 GH action scripts #1529

Add sepolia option to L2 GH action scripts #1529

Conversation

BedrockSquirrel commented Sep 17, 2023 • edited Loading

Why this change is needed

PR checks pre-merging

tudor-malene left a comment

Choose a reason for hiding this comment

otherview left a comment

Choose a reason for hiding this comment

otherview Sep 18, 2023

Choose a reason for hiding this comment

otherview left a comment

Choose a reason for hiding this comment

BedrockSquirrel Sep 25, 2023

Choose a reason for hiding this comment

BedrockSquirrel Sep 26, 2023

Choose a reason for hiding this comment

BedrockSquirrel commented Sep 17, 2023 •

edited

Loading